Re: [Qemu-devel] [PATCH 4/4] qmp-shell: improve help

[Eric Blake]

On 05/04/2017 07:54 AM, Marc-André Lureau wrote:
> Describe the arguments & fix the tool name.
> 
> Signed-off-by: Marc-André Lureau <address@hidden>
> ---
>  scripts/qmp/qmp-shell | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)

Reviewed-by: Eric Blake <address@hidden>

> 
> diff --git a/scripts/qmp/qmp-shell b/scripts/qmp/qmp-shell
> index db24c87cdd..fce1ab6c49 100755
> --- a/scripts/qmp/qmp-shell
> +++ b/scripts/qmp/qmp-shell
> @@ -375,7 +375,11 @@ def die(msg):
>  def fail_cmdline(option=None):
>      if option:
>          sys.stderr.write('ERROR: bad command-line option \'%s\'\n' % option)
> -    sys.stderr.write('qemu-shell [ -v ] [ -p ] [ -H ] [ -N ] < UNIX socket 
> path> | < TCP address:port >\n')
> +    sys.stderr.write('qmp-shell [ -v ] [ -p ] [ -H ] [ -N ] < UNIX socket 
> path> | < TCP address:port >\n')
> +    sys.stderr.write('    -v     Verbose (echo command sent and received)\n')
> +    sys.stderr.write('    -p     Pretty-print JSON\n')
> +    sys.stderr.write('    -H     Use HMP interface\n')
> +    sys.stderr.write('    -N     Skip negotiate (for qemu-ga)\n')
>      sys.exit(1)
>  
>  def main():
> 

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

signature.asc
Description: OpenPGP digital signature