qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 3/4] qmp-shell: don't show version greeting if u


From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH 3/4] qmp-shell: don't show version greeting if unavailable
Date: Thu, 4 May 2017 08:50:46 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.0

On 05/04/2017 07:54 AM, Marc-André Lureau wrote:
> qemu-ga doesn't have greeting.
> 
> Signed-off-by: Marc-André Lureau <address@hidden>
> ---
>  scripts/qmp/qmp-shell | 3 +++
>  1 file changed, 3 insertions(+)
> 

Reviewed-by: Eric Blake <address@hidden>

> diff --git a/scripts/qmp/qmp-shell b/scripts/qmp/qmp-shell
> index 04b8fa3eae..db24c87cdd 100755
> --- a/scripts/qmp/qmp-shell
> +++ b/scripts/qmp/qmp-shell
> @@ -265,6 +265,9 @@ class QMPShell(qmp.QEMUMonitorProtocol):
>  
>      def show_banner(self, msg='Welcome to the QMP low-level shell!'):
>          print msg
> +        if not self._greeting:
> +            print 'Connected'
> +            return
>          version = self._greeting['QMP']['version']['qemu']
>          print 'Connected to QEMU %d.%d.%d\n' % 
> (version['major'],version['minor'],version['micro'])
>  
> 

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]