[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v5 10/10] test-qga: Actually test 0xff sync byte
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v5 10/10] test-qga: Actually test 0xff sync bytes |
Date: |
Thu, 4 May 2017 08:16:26 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.0 |
On 05/04/2017 02:23 AM, Markus Armbruster wrote:
>>> Feel free to suggest something for me to add to the commit message.
>>
>> Maybe change:
>>
>> "which matches the documented actions that a real QGA client
>> is supposed to do."
>>
>> to
>>
>> "which is compatible with the documented actions that a real
>> QGA client is supposed to do."
>>
>> and add the following comment to test_qga_sync_delimited
>>
>> /*
>> * Note that the full reset sequence would involve checking the
>> * response of guest-sync-delimited and repeating the loop if
>> * 'id' field of the response does not match the 'id' field of
>> * the request. Testing this fully would require inserting
>> * garbage in the response stream and is left as a future test
>> * to implement.
>> */
>
> Eric, want me to squash that in?
Yes, those changes are reasonable.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature