[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH qemu v5] memory/iommu: QOM'fy IOMMU MemoryRegion
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-devel] [PATCH qemu v5] memory/iommu: QOM'fy IOMMU MemoryRegion |
|
Date: |
Thu, 4 May 2017 15:03:58 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 |
On 03/05/2017 03:25, Alexey Kardashevskiy wrote:
>> <bikeshed>
>> I find "iommumr" terribly hard to read. Maybe iommu_mr is better? (Lots
>> of times in this patch.)
>> </bikeshed>
> Terribly? Really? :) Seriously, since linux uses underscores in typenames,
> I kind of developed resistance to underscores in variable names which look
> like typenames (even though c allows using same token for a type and a
> variable).
And especially even though QEMU uses camelcase for types. :)
> May be just "iommu"? I need one more vote for "iommu" vs.
> "iommumr" vs. "iommu_mr" to respin v6 :)
I am fine with either iommu or iommu_mr.
Paolo