[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v9 06/10] replay: fix save/load vm for non-empty
From: |
Pavel Dovgalyuk |
Subject: |
Re: [Qemu-devel] [PATCH v9 06/10] replay: fix save/load vm for non-empty queue |
Date: |
Thu, 4 May 2017 13:03:12 +0300 |
> From: Juan Quintela [mailto:address@hidden
> Pavel Dovgalyuk <address@hidden> wrote:
> > From: Pavel Dovgalyuk <address@hidden>
> >
> > This patch does not allows saving/loading vmstate when
> > replay events queue is not empty. There is no reliable
> > way to save events queue, because it describes internal
> > coroutine state. Therefore saving and loading operations
> > should be deferred to another record/replay step.
> >
> > Signed-off-by: Pavel Dovgalyuk <address@hidden>
>
> This functions have changed, see last series (but change is trivial from
> monitor_printf to error_<something>)
>
> > @@ -2083,6 +2084,12 @@ int save_vmstate(Monitor *mon, const char *name)
> > Error *local_err = NULL;
> > AioContext *aio_context;
> >
> > + if (!replay_can_snapshot()) {
> > + monitor_printf(mon, "Record/replay does not allow making snapshot
> > right now. "
> > + "Try stopping at another step.\n");
> > + return ret;
> > + }
> > +
>
> To issue a savevm/loadvm the user don't have to stop qemu, so I think we
> can improve the message to something les in both places?
>
> "Try saving/loading later"?
Right, thanks.
Pavel Dovgalyuk
- [Qemu-devel] [PATCH v9 00/10] replay additions, Pavel Dovgalyuk, 2017/05/04
- [Qemu-devel] [PATCH v9 01/10] block: implement bdrv_snapshot_goto for blkreplay, Pavel Dovgalyuk, 2017/05/04
- [Qemu-devel] [PATCH v9 02/10] blkreplay: create temporary overlay for underlaying devices, Pavel Dovgalyuk, 2017/05/04
- [Qemu-devel] [PATCH v9 03/10] replay: disable default snapshot for record/replay, Pavel Dovgalyuk, 2017/05/04
- [Qemu-devel] [PATCH v9 04/10] replay: fix processing async events, Pavel Dovgalyuk, 2017/05/04
- [Qemu-devel] [PATCH v9 05/10] replay: fixed replay_enable_events, Pavel Dovgalyuk, 2017/05/04
- [Qemu-devel] [PATCH v9 06/10] replay: fix save/load vm for non-empty queue, Pavel Dovgalyuk, 2017/05/04
- Re: [Qemu-devel] [PATCH v9 06/10] replay: fix save/load vm for non-empty queue, Juan Quintela, 2017/05/04
- Re: [Qemu-devel] [PATCH v9 06/10] replay: fix save/load vm for non-empty queue,
Pavel Dovgalyuk <=
- Re: [Qemu-devel] [PATCH v9 06/10] replay: fix save/load vm for non-empty queue, Paolo Bonzini, 2017/05/04
- Re: [Qemu-devel] [PATCH v9 06/10] replay: fix save/load vm for non-empty queue, Pavel Dovgalyuk, 2017/05/04
- Re: [Qemu-devel] [PATCH v9 06/10] replay: fix save/load vm for non-empty queue, Paolo Bonzini, 2017/05/04
- Re: [Qemu-devel] [PATCH v9 06/10] replay: fix save/load vm for non-empty queue, Pavel Dovgalyuk, 2017/05/04
- Re: [Qemu-devel] [PATCH v9 06/10] replay: fix save/load vm for non-empty queue, Paolo Bonzini, 2017/05/04
- Re: [Qemu-devel] [PATCH v9 06/10] replay: fix save/load vm for non-empty queue, Pavel Dovgalyuk, 2017/05/04
- Re: [Qemu-devel] [PATCH v9 06/10] replay: fix save/load vm for non-empty queue, Paolo Bonzini, 2017/05/04
- Re: [Qemu-devel] [PATCH v9 06/10] replay: fix save/load vm for non-empty queue, Pavel Dovgalyuk, 2017/05/04
- Re: [Qemu-devel] [PATCH v9 06/10] replay: fix save/load vm for non-empty queue, Paolo Bonzini, 2017/05/04
- Re: [Qemu-devel] [PATCH v9 06/10] replay: fix save/load vm for non-empty queue, Pavel Dovgalyuk, 2017/05/04