Re: [Qemu-devel] [PATCH v5++ 1/3] tcg/mips: implement goto_ptr

[Aurelien Jarno]

On 2017-05-02 18:21, Richard Henderson wrote:
> On 04/30/2017 04:52 PM, Aurelien Jarno wrote:
> > +        /* jmp to the given host address (could be epilogue) */
> > +        tcg_out_opc_reg(s, OPC_JR, 0, a0, 0);
> > +        tcg_out_nop(s);
> 
> Any particular reason not to do the zeroing in the delay slot...
> 
> > +    s->code_gen_epilogue = s->code_ptr;
> > +    tcg_out_mov(s, TCG_TYPE_REG, TCG_REG_V0, TCG_REG_ZERO);
> 
> ... instead of here?

There is no particular reason in the current usage of goto_ptr. It's
just that in the future we might want to use code_gen_epilogue for
other reasons or use the tcg_out_opc_reg to do other things. It's
probably better to have a consistent behaviour across all TCG
targets.

That said if you prefer, I am find sending a v2 with the zeroing moved
to the delay slot.

-- 
Aurelien Jarno                          GPG: 4096R/1DDD8C9B
address@hidden                 http://www.aurel32.net