[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v17 16/23] file-win32: Error out if locking=on
From: |
Fam Zheng |
Subject: |
[Qemu-devel] [PATCH v17 16/23] file-win32: Error out if locking=on |
Date: |
Wed, 3 May 2017 00:35:51 +0800 |
We share the same set of QAPI options with file-posix, but locking is
not supported here. So error out if it is specified as 'on' for now.
Signed-off-by: Fam Zheng <address@hidden>
---
block/file-win32.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/block/file-win32.c b/block/file-win32.c
index 7872e00..534021b 100644
--- a/block/file-win32.c
+++ b/block/file-win32.c
@@ -344,6 +344,11 @@ static int raw_open(BlockDriverState *bs, QDict *options,
int flags,
goto fail;
}
+ if (qdict_get_try_bool(options, "locking", false)) {
+ error_setg(errp, "locking=on is not supported on Windows");
+ goto fail;
+ }
+
filename = qemu_opt_get(opts, "filename");
use_aio = get_aio_option(opts, flags, &local_err);
--
2.9.3
- [Qemu-devel] [PATCH v17 06/23] qemu-io: Add --force-share option, (continued)
- [Qemu-devel] [PATCH v17 06/23] qemu-io: Add --force-share option, Fam Zheng, 2017/05/02
- [Qemu-devel] [PATCH v17 08/23] iotests: 046: Prepare for image locking, Fam Zheng, 2017/05/02
- [Qemu-devel] [PATCH v17 07/23] iotests: 030: Prepare for image locking, Fam Zheng, 2017/05/02
- [Qemu-devel] [PATCH v17 09/23] iotests: 055: Don't attach the target image already for drive-backup, Fam Zheng, 2017/05/02
- [Qemu-devel] [PATCH v17 11/23] iotests: 087: Don't attach test image twice, Fam Zheng, 2017/05/02
- [Qemu-devel] [PATCH v17 10/23] iotests: 085: Avoid image locking conflict, Fam Zheng, 2017/05/02
- [Qemu-devel] [PATCH v17 12/23] iotests: 091: Quit QEMU before checking image, Fam Zheng, 2017/05/02
- [Qemu-devel] [PATCH v17 13/23] iotests: 172: Use separate images for multiple devices, Fam Zheng, 2017/05/02
- [Qemu-devel] [PATCH v17 14/23] tests: Use null-co:// instead of /dev/null as the dummy image, Fam Zheng, 2017/05/02
- [Qemu-devel] [PATCH v17 15/23] file-posix: Add 'locking' option, Fam Zheng, 2017/05/02
- [Qemu-devel] [PATCH v17 16/23] file-win32: Error out if locking=on,
Fam Zheng <=
- [Qemu-devel] [PATCH v17 17/23] tests: Disable image lock in test-replication, Fam Zheng, 2017/05/02
- [Qemu-devel] [PATCH v17 18/23] block: Reuse bs as backing hd for drive-backup sync=none, Fam Zheng, 2017/05/02
- [Qemu-devel] [PATCH v17 19/23] osdep: Add qemu_lock_fd and qemu_unlock_fd, Fam Zheng, 2017/05/02
- [Qemu-devel] [PATCH v17 20/23] osdep: Fall back to posix lock when OFD lock is unavailable, Fam Zheng, 2017/05/02
- [Qemu-devel] [PATCH v17 21/23] file-posix: Add image locking to perm operations, Fam Zheng, 2017/05/02
- [Qemu-devel] [PATCH v17 23/23] tests: Add POSIX image locking test case 182, Fam Zheng, 2017/05/02
- [Qemu-devel] [PATCH v17 22/23] qemu-iotests: Add test case 153 for image locking, Fam Zheng, 2017/05/02