qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] Deprecate '-enable-kvm' and '-enable-hax' in fa


From: Paolo Bonzini
Subject: Re: [Qemu-devel] [PATCH] Deprecate '-enable-kvm' and '-enable-hax' in favour of '-accel'
Date: Tue, 2 May 2017 17:09:42 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0


On 02/05/2017 17:01, Markus Armbruster wrote:
>> But I really, really see no point in removing --enable-kvm.  It costs
>> perhaps 10 lines of code that has pretty much no ramifications elsewhere
>> in the code.  If anything I'd expect "-machine accel" to disappear
>> before, if ever (in favor of multiple "-accel" options, e.g. "-machine
>> accel=kvm:tcg" can become "-accel kvm -accel tcg".
> I basically agree, except I wouldn't say "no point", but "doesn't buy us
> enough to justify inconveniencing users".
> 
> What we've done before for options that have become unloved, but not
> harmful, is remove them just from documentation.  Grep qemu-options.hx
> for "HXCOMM Deprecated".  Let's do that for --enable-kvm and similarly
> weird sugared options.

Except that this provides no easily greppable way to find how to enable
KVM, as things stand.  So the first lesson should be "no deprecation
without documentation" (any reference to 18th century political slogans
is purely coincidential :)).

Paolo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]