Re: [Qemu-devel] [PATCH 2/2] ramblock: add new hmp command "info ramblock"

[Peter Xu]

On Wed, Apr 26, 2017 at 02:10:16PM +0200, Markus Armbruster wrote:
> Peter Xu <address@hidden> writes:
> 
> > To dump information about ramblocks. It looks like:
> >
> > (qemu) info ramblock
> >               Block Name    PSize              Offset               Used    
> >           Total
> >             /objects/mem       2M  0x0000000000000000 0x0000000080000000 
> > 0x0000000080000000
> >                 vga.vram       4K  0x0000000080060000 0x0000000001000000 
> > 0x0000000001000000
> >     /address@hidden/acpi/tables       4K  0x00000000810b0000 
> > 0x0000000000020000 0x0000000000200000
> >                  pc.bios       4K  0x0000000080000000 0x0000000000040000 
> > 0x0000000000040000
> >   0000:00:03.0/e1000.rom       4K  0x0000000081070000 0x0000000000040000 
> > 0x0000000000040000
> >                   pc.rom       4K  0x0000000080040000 0x0000000000020000 
> > 0x0000000000020000
> >     0000:00:02.0/vga.rom       4K  0x0000000081060000 0x0000000000010000 
> > 0x0000000000010000
> >    /address@hidden/table-loader       4K  0x00000000812b0000 
> > 0x0000000000001000 0x0000000000001000
> >       /address@hidden/acpi/rsdp       4K  0x00000000812b1000 
> > 0x0000000000001000 0x0000000000001000
> >
> > Signed-off-by: Peter Xu <address@hidden>
> 
> You implemented this just for HMP.
> 
> In general, functionality available in HMP should also available in QMP.
> Exceptions include functionality that makes no sense in QMP, or is of
> use only for human users.  If you think your command is an exception,
> please explain why in the commit message.
> 
> If it isn't, you need to implement it for QMP, then rewrite the HMP
> version to reuse either the QMP command or a common core.

I see. I think it should belongs to the first condition, which should
only be used by human users, especially developers. Maybe I can repost
with some more comment in the commit message to emphasize that.

But, before that, I would also want to know whether anyone would think
this an useful thing even to QMP... If so, I would be glad to provide
QMP interface as well.

Thanks,

-- 
Peter Xu