[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 11/24] block: bdrv_close: release bitmaps after drv-
From: |
Vladimir Sementsov-Ogievskiy |
Subject: |
[Qemu-devel] [PATCH 11/24] block: bdrv_close: release bitmaps after drv->bdrv_close |
Date: |
Wed, 26 Apr 2017 14:30:25 +0300 |
Release bitmaps after 'if (bs->drv) { ... }' block. This will allow
format driver to save persistent bitmaps, which will appear in following
commits.
Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
---
block.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/block.c b/block.c
index a0346c80c6..16cf522219 100644
--- a/block.c
+++ b/block.c
@@ -2322,9 +2322,6 @@ static void bdrv_close(BlockDriverState *bs)
bdrv_flush(bs);
bdrv_drain(bs); /* in case flush left pending I/O */
- bdrv_release_named_dirty_bitmaps(bs);
- assert(QLIST_EMPTY(&bs->dirty_bitmaps));
-
if (bs->drv) {
BdrvChild *child, *next;
@@ -2363,6 +2360,9 @@ static void bdrv_close(BlockDriverState *bs)
bs->full_open_options = NULL;
}
+ bdrv_release_named_dirty_bitmaps(bs);
+ assert(QLIST_EMPTY(&bs->dirty_bitmaps));
+
QLIST_FOREACH_SAFE(ban, &bs->aio_notifiers, list, ban_next) {
g_free(ban);
}
--
2.11.1
- [Qemu-devel] [PATCH 16/24] qcow2: add .bdrv_can_store_new_dirty_bitmap, (continued)
- [Qemu-devel] [PATCH 16/24] qcow2: add .bdrv_can_store_new_dirty_bitmap, Vladimir Sementsov-Ogievskiy, 2017/04/26
- [Qemu-devel] [PATCH 17/24] qmp: add persistent flag to block-dirty-bitmap-add, Vladimir Sementsov-Ogievskiy, 2017/04/26
- [Qemu-devel] [PATCH 15/24] block: add bdrv_can_store_new_dirty_bitmap, Vladimir Sementsov-Ogievskiy, 2017/04/26
- [Qemu-devel] [PATCH 20/24] iotests: test qcow2 persistent dirty bitmap, Vladimir Sementsov-Ogievskiy, 2017/04/26
- [Qemu-devel] [PATCH 08/24] qcow2: add bitmaps extension, Vladimir Sementsov-Ogievskiy, 2017/04/26
- [Qemu-devel] [PATCH 07/24] qcow2-refcount: rename inc_refcounts() and make it public, Vladimir Sementsov-Ogievskiy, 2017/04/26
- [Qemu-devel] [PATCH 02/24] specs/qcow2: do not use wording 'bitmap header', Vladimir Sementsov-Ogievskiy, 2017/04/26
- [Qemu-devel] [PATCH 24/24] block: release persistent bitmaps on inactivate, Vladimir Sementsov-Ogievskiy, 2017/04/26
- [Qemu-devel] [PATCH 09/24] qcow2: autoloading dirty bitmaps, Vladimir Sementsov-Ogievskiy, 2017/04/26
- [Qemu-devel] [PATCH 14/24] qcow2: add persistent dirty bitmaps support, Vladimir Sementsov-Ogievskiy, 2017/04/26
- [Qemu-devel] [PATCH 11/24] block: bdrv_close: release bitmaps after drv->bdrv_close,
Vladimir Sementsov-Ogievskiy <=
- [Qemu-devel] [PATCH 21/24] block/dirty-bitmap: add bdrv_remove_persistent_dirty_bitmap, Vladimir Sementsov-Ogievskiy, 2017/04/26
- [Qemu-devel] [PATCH 04/24] tests: add hbitmap iter test, Vladimir Sementsov-Ogievskiy, 2017/04/26
- [Qemu-devel] [PATCH 13/24] block/dirty-bitmap: add bdrv_dirty_bitmap_next(), Vladimir Sementsov-Ogievskiy, 2017/04/26
- [Qemu-devel] [PATCH 22/24] qcow2: add .bdrv_remove_persistent_dirty_bitmap, Vladimir Sementsov-Ogievskiy, 2017/04/26
- [Qemu-devel] [PATCH 12/24] block: introduce persistent dirty bitmaps, Vladimir Sementsov-Ogievskiy, 2017/04/26
- [Qemu-devel] [PATCH 03/24] hbitmap: improve dirty iter, Vladimir Sementsov-Ogievskiy, 2017/04/26
- [Qemu-devel] [PATCH 19/24] qmp: add x-debug-block-dirty-bitmap-sha256, Vladimir Sementsov-Ogievskiy, 2017/04/26
- [Qemu-devel] [PATCH 23/24] qmp: block-dirty-bitmap-remove: remove persistent, Vladimir Sementsov-Ogievskiy, 2017/04/26
- Re: [Qemu-devel] [PATCH v17 00/24] qcow2: persistent dirty bitmaps, John Snow, 2017/04/27