Re: [Qemu-devel] [PATCH 1/1] slirp: don't zero ti_i since we acccess it later.

[Thomas Huth]

On 20.04.2017 22:43, Tao Wu wrote:
> The current code looks buggy, we zero ti_i while we access
> ti_dst/ti_src later.
> 
> Signed-off-by: Tao Wu <address@hidden>
> ---
>  slirp/tcp_subr.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/slirp/tcp_subr.c b/slirp/tcp_subr.c
> index dc8b4bbb50..398d6b30d3 100644
> --- a/slirp/tcp_subr.c
> +++ b/slirp/tcp_subr.c
> @@ -148,7 +148,6 @@ tcp_respond(struct tcpcb *tp, struct tcpiphdr *ti, struct 
> mbuf *m,
>               m->m_data += IF_MAXLINKHDR;
>               *mtod(m, struct tcpiphdr *) = *ti;
>               ti = mtod(m, struct tcpiphdr *);
> -             memset(&ti->ti, 0, sizeof(ti->ti));
>               flags = TH_ACK;
>       } else {
>               /*

When providing patches, please make sure to put the subsystem maintainer
on CC: (see MAINTAINERS file) - or your patch will likely be lost in the
high traffic of the qemu-devel mailing list.

 Thanks,
  Thomas