[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 14/15] qdev: Constify value passed to qdev_prop_set_m
From: |
Eduardo Habkost |
Subject: |
[Qemu-devel] [PULL 14/15] qdev: Constify value passed to qdev_prop_set_macaddr |
Date: |
Thu, 20 Apr 2017 15:47:04 -0300 |
From: Krzysztof Kozlowski <address@hidden>
The 'value' argument is not modified so this can be made const for code
safeness.
Signed-off-by: Krzysztof Kozlowski <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Eduardo Habkost <address@hidden>
---
include/hw/qdev-properties.h | 3 ++-
hw/core/qdev-properties.c | 3 ++-
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/include/hw/qdev-properties.h b/include/hw/qdev-properties.h
index 7ac315331a..1d69fa7a8f 100644
--- a/include/hw/qdev-properties.h
+++ b/include/hw/qdev-properties.h
@@ -188,7 +188,8 @@ void qdev_prop_set_chr(DeviceState *dev, const char *name,
Chardev *value);
void qdev_prop_set_netdev(DeviceState *dev, const char *name, NetClientState
*value);
void qdev_prop_set_drive(DeviceState *dev, const char *name,
BlockBackend *value, Error **errp);
-void qdev_prop_set_macaddr(DeviceState *dev, const char *name, uint8_t *value);
+void qdev_prop_set_macaddr(DeviceState *dev, const char *name,
+ const uint8_t *value);
void qdev_prop_set_enum(DeviceState *dev, const char *name, int value);
/* FIXME: Remove opaque pointer properties. */
void qdev_prop_set_ptr(DeviceState *dev, const char *name, void *value);
diff --git a/hw/core/qdev-properties.c b/hw/core/qdev-properties.c
index 6ab4265eb4..fa3617db2d 100644
--- a/hw/core/qdev-properties.c
+++ b/hw/core/qdev-properties.c
@@ -1010,7 +1010,8 @@ void qdev_prop_set_string(DeviceState *dev, const char
*name, const char *value)
object_property_set_str(OBJECT(dev), value, name, &error_abort);
}
-void qdev_prop_set_macaddr(DeviceState *dev, const char *name, uint8_t *value)
+void qdev_prop_set_macaddr(DeviceState *dev, const char *name,
+ const uint8_t *value)
{
char str[2 * 6 + 5 + 1];
snprintf(str, sizeof(str), "%02x:%02x:%02x:%02x:%02x:%02x",
--
2.11.0.259.g40922b1
- [Qemu-devel] [PULL 04/15] memory: introduce memory_region_notify_one(), (continued)
- [Qemu-devel] [PULL 04/15] memory: introduce memory_region_notify_one(), Eduardo Habkost, 2017/04/20
- [Qemu-devel] [PULL 05/15] memory: add MemoryRegionIOMMUOps.replay() callback, Eduardo Habkost, 2017/04/20
- [Qemu-devel] [PULL 06/15] intel_iommu: use the correct memory region for device IOTLB notification, Eduardo Habkost, 2017/04/20
- [Qemu-devel] [PULL 07/15] intel_iommu: provide its own replay() callback, Eduardo Habkost, 2017/04/20
- [Qemu-devel] [PULL 08/15] intel_iommu: allow dynamic switch of IOMMU region, Eduardo Habkost, 2017/04/20
- [Qemu-devel] [PULL 10/15] qdev: Make "hotplugged" property read-only, Eduardo Habkost, 2017/04/20
- [Qemu-devel] [PULL 09/15] intel_iommu: enable remote IOTLB, Eduardo Habkost, 2017/04/20
- [Qemu-devel] [PULL 11/15] hw/core/null-machine: Print error message when using the -kernel parameter, Eduardo Habkost, 2017/04/20
- [Qemu-devel] [PULL 12/15] hostmem: introduce host_memory_backend_mr_inited(), Eduardo Habkost, 2017/04/20
- [Qemu-devel] [PULL 13/15] hostmem: use host_memory_backend_mr_inited() where proper, Eduardo Habkost, 2017/04/20
- [Qemu-devel] [PULL 14/15] qdev: Constify value passed to qdev_prop_set_macaddr,
Eduardo Habkost <=
- [Qemu-devel] [PULL 15/15] qdev: Constify local variable returned by blk_bs, Eduardo Habkost, 2017/04/20
- Re: [Qemu-devel] [PULL 00/15] Machine queue for 2.10, Peter Maydell, 2017/04/21