[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2] event: Add source information to SHUTDOWN
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v2] event: Add source information to SHUTDOWN |
Date: |
Thu, 20 Apr 2017 08:20:11 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.0 |
On 04/20/2017 07:09 AM, Daniel P. Berrange wrote:
>>> +++ b/qapi/event.json
>>> @@ -10,6 +10,10 @@
>>> # Emitted when the virtual machine has shut down, indicating that qemu is
>>> # about to exit.
>>> #
>>> +# @guest: If true, the shutdown was triggered by a guest request (such as
>>> +# executing a halt instruction) rather than a host request (such as sending
>>> +# qemu a SIGINT). (since 2.10)
>>> +#
>>
>> "executing a halt instruction" suggests "halt" is a machine instruction.
Which is indeed what most of the places I patched to pass 'true' are
emulating - the machine halt instruction.
>> I think you mean /usr/sbin/halt. Suggest something like "executing a
>> halt command".
>
> Well technically /usr/sbin/halt just terminates all processes / kernel and
> halts CPUs, but the virtual machine is still active (and a 'reset' in the
> monitor can start it again. /usr/sbin/poweroff is what actually does the
> ACPI poweroff to trigger QEMU to exit[1]
I'm thinking of this wording:
triggered by a guest request (such as the guest running
/usr/sbin/poweroff to trigger an ACPI shutdown or machine halt instruction)
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
Re: [Qemu-devel] [PATCH v2] event: Add source information to SHUTDOWN, Eric Blake, 2017/04/20