[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 2/3] colo-compare: Check main_loop value before call
From: |
zhanghailiang |
Subject: |
[Qemu-devel] [PATCH 2/3] colo-compare: Check main_loop value before call g_main_loop_quit |
Date: |
Thu, 20 Apr 2017 15:46:54 +0800 |
If some errors happen before main_loop is initialized in colo
compare thread, qemu will go into finalizing process where
we call g_main_loop_quit(s->main_loop), if main_loop is NULL, there
will be an error report:
"(process:14861): GLib-CRITICAL **: g_main_loop_quit: assertion 'loop != NULL'
failed".
We need to check if main_loop is NULL or not before call g_main_loop_quit().
Signed-off-by: zhanghailiang <address@hidden>
---
net/colo-compare.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/net/colo-compare.c b/net/colo-compare.c
index a6bf419..d6a5e4c 100644
--- a/net/colo-compare.c
+++ b/net/colo-compare.c
@@ -770,7 +770,9 @@ static void colo_compare_finalize(Object *obj)
s->worker_context, true);
qemu_chr_fe_deinit(&s->chr_out);
- g_main_loop_quit(s->compare_loop);
+ if (s->compare_loop) {
+ g_main_loop_quit(s->compare_loop);
+ }
qemu_thread_join(&s->thread);
/* Release all unhandled packets after compare thead exited */
--
1.8.3.1
- [Qemu-devel] [PATCH 0/3] colo-compare: fix three bugs, zhanghailiang, 2017/04/20
- [Qemu-devel] [PATCH 2/3] colo-compare: Check main_loop value before call g_main_loop_quit,
zhanghailiang <=
- [Qemu-devel] [PATCH 3/3] colo-compare: fix a memory leak, zhanghailiang, 2017/04/20
- [Qemu-devel] [PATCH 1/3] colo-compare: serialize compare thread's initialization with main thread, zhanghailiang, 2017/04/20
- Re: [Qemu-devel] [PATCH 1/3] colo-compare: serialize compare thread's initialization with main thread, Jason Wang, 2017/04/24
- Re: [Qemu-devel] [PATCH 1/3] colo-compare: serialize compare thread's initialization with main thread, Hailiang Zhang, 2017/04/24
- Re: [Qemu-devel] [PATCH 1/3] colo-compare: serialize compare thread's initialization with main thread, Jason Wang, 2017/04/25
- Re: [Qemu-devel] [PATCH 1/3] colo-compare: serialize compare thread's initialization with main thread, Hailiang Zhang, 2017/04/25
- Re: [Qemu-devel] [PATCH 1/3] colo-compare: serialize compare thread's initialization with main thread, Jason Wang, 2017/04/25
- Re: [Qemu-devel] [PATCH 1/3] colo-compare: serialize compare thread's initialization with main thread, Hailiang Zhang, 2017/04/26