[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 48/54] ram: Use page number instead of an addres
From: |
Juan Quintela |
Subject: |
Re: [Qemu-devel] [PATCH 48/54] ram: Use page number instead of an address for the bitmap operations |
Date: |
Tue, 18 Apr 2017 21:18:18 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) |
"Dr. David Alan Gilbert" <address@hidden> wrote:
> * Juan Quintela (address@hidden) wrote:
>> We use an unsigned long for the page number. Notice that our bitmaps
>> already got that for the index, so we have that limit.
>>
>> Signed-off-by: Juan Quintela <address@hidden>
>
> see below....
>> index 7372ce2..9514044 100644
>> --- a/migration/trace-events
>> +++ b/migration/trace-events
>> @@ -63,8 +63,8 @@ put_qtailq_end(const char *name, const char *reason) "%s
>> %s"
>> qemu_file_fclose(void) ""
>>
>> # migration/ram.c
>> -get_queued_page(const char *block_name, uint64_t tmp_offset, uint64_t
>> ram_addr) "%s/%" PRIx64 " ram_addr=%" PRIx64
>> -get_queued_page_not_dirty(const char *block_name, uint64_t tmp_offset,
>> uint64_t ram_addr, int sent) "%s/%" PRIx64 " ram_addr=%" PRIx64 " (sent=%d)"
>> +get_queued_page(const char *block_name, uint64_t tmp_offset, unsigned long
>> page_abs) "%s/%" PRIx64 " page_abs=%lu"
>> +get_queued_page_not_dirty(const char *block_name, uint64_t tmp_offset,
>> unsigned long page_abs, int sent) "%s/%" PRIx64 " page_abs=%lu (sent=%d)"
>
> Yes, but if you respin, please make those %lx rather than %lu.
Done.
> Reviewed-by: Dr. David Alan Gilbert <address@hidden>
- [Qemu-devel] [PATCH 42/54] ram: We don't need MigrationState parameter anymore, (continued)
- [Qemu-devel] [PATCH 42/54] ram: We don't need MigrationState parameter anymore, Juan Quintela, 2017/04/06
- [Qemu-devel] [PATCH 45/54] ram: Pass RAMBlock to bitmap_sync, Juan Quintela, 2017/04/06
- [Qemu-devel] [PATCH 46/54] ram: ram_discard_range() don't use the mis parameter, Juan Quintela, 2017/04/06
- [Qemu-devel] [PATCH 44/54] ram: Add page-size to output in 'info migrate', Juan Quintela, 2017/04/06
- [Qemu-devel] [PATCH 47/54] ram: reorganize last_sent_block, Juan Quintela, 2017/04/06
- [Qemu-devel] [PATCH 49/54] ram: Remember last_page instead of last_offset, Juan Quintela, 2017/04/06
- [Qemu-devel] [PATCH 48/54] ram: Use page number instead of an address for the bitmap operations, Juan Quintela, 2017/04/06
- [Qemu-devel] [PATCH 50/54] ram: Change offset field in PageSearchStatus to page, Juan Quintela, 2017/04/06
- [Qemu-devel] [PATCH 51/54] ram: Use ramblock and page offset instead of absolute offset, Juan Quintela, 2017/04/06
- [Qemu-devel] [PATCH 52/54] ram: rename last_ram_offset() last_ram_pages(), Juan Quintela, 2017/04/06
- [Qemu-devel] [PATCH 53/54] ram: Use RAMBitmap type for coherence, Juan Quintela, 2017/04/06
- [Qemu-devel] [PATCH 54/54] migration: Remove MigrationState parameter from migration_is_idle(), Juan Quintela, 2017/04/06