[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] spapr-cpu-core: Release ICPState object during
|
From: |
Bharata B Rao |
|
Subject: |
Re: [Qemu-devel] [PATCH] spapr-cpu-core: Release ICPState object during CPU unrealization |
|
Date: |
Wed, 12 Apr 2017 14:23:00 +0530 |
|
User-agent: |
Mutt/1.7.1 (2016-10-04) |
On Wed, Apr 12, 2017 at 10:47:39AM +0200, Cédric Le Goater wrote:
> On 04/12/2017 10:15 AM, Bharata B Rao wrote:
> > Recent commits that re-organized ICPState object missed to destroy
> > the object when CPU is unrealized. Fix this so that CPU unplug
> > doesn't abort QEMU.
>
> Indeed.
>
> > Signed-off-by: Bharata B Rao <address@hidden>
>
> I am wondering if we should not be doing the unparent under
> spapr_cpu_destroy() or even xics_cpu_destroy(). Apart from
> that,
Thought so, but since object is created in realize routinte itself
(and not in any of its callers), did the object destruction in
unrealize to be symmetrical :)
Regards,
Bharata.