Re: [Qemu-devel] [PATCH for-2.10 14/19] crypto: cipher: add af_alg cipher support

[Daniel P. Berrange]

On Mon, Apr 10, 2017 at 06:52:29PM +0800, Longpeng (Mike) wrote:
> 
> On 2017/4/10 18:18, Daniel P. Berrange wrote:
> 
> > On Mon, Apr 10, 2017 at 05:00:52PM +0800, Longpeng(Mike) wrote:
> >> Adds afalg-backend cipher support: introduces some private APIs
> >> firstly, and then intergrates them into qcrypto_cipher_afalg_driver.
> >>
> >> Signed-off-by: Longpeng(Mike) <address@hidden>
> >> ---
> >>  crypto/Makefile.objs        |   1 +
> >>  crypto/cipher-afalg.c       | 229 
> >> ++++++++++++++++++++++++++++++++++++++++++++
> >>  crypto/cipher.c             |  30 +++++-
> >>  include/crypto/afalg-comm.h |  11 +++
> >>  include/crypto/cipher.h     |   7 ++
> >>  tests/test-crypto-cipher.c  |  10 +-
> >>  6 files changed, 286 insertions(+), 2 deletions(-)
> >>  create mode 100644 crypto/cipher-afalg.c
> >>
> > 
> 
> ...
> 
> > 
> > 
> > All methods in this file should be named 'qcrypto_afalg_...'
> > 
> 
> 
> Hi Daniel,
> 
> Now the libiary-backend methods are named as 
> "nettle(gcrypt,glib,builtin)_...",
> so if I rename them with "qcrypto_afalg_" prefix , then the libiary-backend
> methods need with "qcrypto_nettle(gcrypt,glib,builtin)_" prefix , right ?

Yep, that's right - every method in the crypto/ directory should have a
qcrypto_ name prefix, even if it is a static method.


Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://entangle-photo.org       -o-    http://search.cpan.org/~danberr/ :|