Re: [Qemu-devel] [PATCH v2 9/9] tpm: Added support for TPM emulator

[Marc-André Lureau]

Hi

On Fri, Apr 7, 2017 at 4:41 PM Daniel P. Berrange

> > +        .name = "data-path",
> > +        .type = QEMU_OPT_STRING,
> > +        .help = "Socket path to use for data exhange",
> > +    },
> > +    {
> > +        .name = "ctrl-path",
> > +        .type = QEMU_OPT_STRING,
> > +        .help = "Socket path to use for out-of-band control messages",
> > +    },
>
> I'm still not convinced by the need for 2 separate UNIX sockets, unless
> there's a performance reason, but that looks unlikely.
>
>
We would also need something more than an implementation of the protocol
that qemu is going to rely on as an external dependency.  A protocol
specification would help to start the discussion. Alternatively, I would
suggest to not rely on a public protocol, and implement the helper as part
of qemu with a private protocol (but still documented).

-- 
Marc-André Lureau