Re: [Qemu-devel] [PATCH v2 21/21] s390-pcibus: No need to set user_creatable=false explicitly

[Cornelia Huck]

On Tue,  4 Apr 2017 17:24:29 -0300
Eduardo Habkost <address@hidden> wrote:

> TYPE_S390_PCI_HOST_BRIDGE is a subclass of TYPE_PCI_HOST_BRIDGE,
> which is a subclass of TYPE_SYS_BUS_DEVICE. TYPE_SYS_BUS_DEVICE
> already sets user_creatable=false, so we don't require an
> explicit user_creatable=false assignment in
> s390_pcihost_class_init().
> 
> Cc: Alexander Graf <address@hidden>
> Cc: Christian Borntraeger <address@hidden>
> Cc: Cornelia Huck <address@hidden>
> Cc: Frank Blaschka <address@hidden>
> Cc: Laszlo Ersek <address@hidden>
> Cc: Marcel Apfelbaum <address@hidden>
> Cc: Markus Armbruster <address@hidden>
> Cc: Peter Maydell <address@hidden>
> Cc: Pierre Morel <address@hidden>
> Cc: Richard Henderson <address@hidden>
> Cc: Thomas Huth <address@hidden>
> Cc: Yi Min Zhao <address@hidden>
> Signed-off-by: Eduardo Habkost <address@hidden>
> ---
> Changes series v1 -> v2:
> * Previous patch was:
>   "s390: Add FIXME for unexplained user_creatable=false line",
>   but now we know we can remove the explicit user_creatable=false
>   assignment
> ---
>  hw/s390x/s390-pci-bus.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/hw/s390x/s390-pci-bus.c b/hw/s390x/s390-pci-bus.c
> index 1ec30c45ce..973893df07 100644
> --- a/hw/s390x/s390-pci-bus.c
> +++ b/hw/s390x/s390-pci-bus.c
> @@ -867,7 +867,6 @@ static void s390_pcihost_class_init(ObjectClass *klass, 
> void *data)
>      DeviceClass *dc = DEVICE_CLASS(klass);
>      HotplugHandlerClass *hc = HOTPLUG_HANDLER_CLASS(klass);
>  
> -    dc->user_creatable = false;
>      dc->reset = s390_pcihost_reset;
>      k->init = s390_pcihost_init;
>      hc->plug = s390_pcihost_hot_plug;

Acked-by: Cornelia Huck <address@hidden>