[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC QEMU PATCH v2 01/10] nvdimm xen: disable label sup
From: |
Konrad Rzeszutek Wilk |
Subject: |
Re: [Qemu-devel] [RFC QEMU PATCH v2 01/10] nvdimm xen: disable label support on Xen |
Date: |
Sat, 1 Apr 2017 08:25:18 -0400 |
User-agent: |
Mutt/1.8.0 (2017-02-23) |
On Mon, Mar 20, 2017 at 08:12:40AM +0800, Haozhong Zhang wrote:
> If xen_enabled(), memory_region_get_ram_ptr() always returns NULL and
> nvdimm_realize() cannot get the correct pointer to the label area. This
> commit disables the label support for Xen accelerator to workaround
> this issue.
>
> Signed-off-by: Haozhong Zhang <address@hidden>
> ---
> Cc: "Michael S. Tsirkin" <address@hidden>
> Cc: Igor Mammedov <address@hidden>
> Cc: Xiao Guangrong <address@hidden>
> ---
> hw/mem/nvdimm.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/hw/mem/nvdimm.c b/hw/mem/nvdimm.c
> index db896b0bb6..0d3e17e94c 100644
> --- a/hw/mem/nvdimm.c
> +++ b/hw/mem/nvdimm.c
> @@ -87,7 +87,11 @@ static void nvdimm_realize(PCDIMMDevice *dimm, Error
> **errp)
> align = memory_region_get_alignment(mr);
>
> pmem_size = size - nvdimm->label_size;
> - nvdimm->label_data = memory_region_get_ram_ptr(mr) + pmem_size;
> + /*
> + * TODO: explain the reason
Ahem?
> + */
> + if (nvdimm->label_size)
> + nvdimm->label_data = memory_region_get_ram_ptr(mr) + pmem_size;
> pmem_size = QEMU_ALIGN_DOWN(pmem_size, align);
>
> if (size <= nvdimm->label_size || !pmem_size) {
> --
> 2.12.0
>
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [Qemu-devel] [RFC QEMU PATCH v2 01/10] nvdimm xen: disable label support on Xen,
Konrad Rzeszutek Wilk <=