[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/5] migration: set current_active_state once
From: |
Dr. David Alan Gilbert |
Subject: |
Re: [Qemu-devel] [PATCH 1/5] migration: set current_active_state once |
Date: |
Fri, 31 Mar 2017 19:50:31 +0100 |
User-agent: |
Mutt/1.8.0 (2017-02-23) |
* Peter Xu (address@hidden) wrote:
> We set it right above this one. No need to set it twice.
Ah good spot, yes set in the declaration of current_active_state.
> CC: Juan Quintela <address@hidden>
> CC: "Dr. David Alan Gilbert" <address@hidden>
> Signed-off-by: Peter Xu <address@hidden>
> ---
> migration/migration.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/migration/migration.c b/migration/migration.c
> index 54060f7..f9f4d98 100644
> --- a/migration/migration.c
> +++ b/migration/migration.c
> @@ -1938,7 +1938,6 @@ static void *migration_thread(void *opaque)
> qemu_savevm_state_begin(s->to_dst_file, &s->params);
>
> s->setup_time = qemu_clock_get_ms(QEMU_CLOCK_HOST) - setup_start;
> - current_active_state = MIGRATION_STATUS_ACTIVE;
> migrate_set_state(&s->state, MIGRATION_STATUS_SETUP,
> MIGRATION_STATUS_ACTIVE);
Reviewed-by: Dr. David Alan Gilbert <address@hidden>
>
> --
> 2.7.4
>
--
Dr. David Alan Gilbert / address@hidden / Manchester, UK
- [Qemu-devel] [PATCH 0/5] several migrations related patches, Peter Xu, 2017/03/27
- [Qemu-devel] [PATCH 1/5] migration: set current_active_state once, Peter Xu, 2017/03/27
- Re: [Qemu-devel] [PATCH 1/5] migration: set current_active_state once,
Dr. David Alan Gilbert <=
- [Qemu-devel] [PATCH 2/5] migration: rename max_size to threshold_size, Peter Xu, 2017/03/27
- [Qemu-devel] [PATCH 3/5] hmp: info migrate_capability format tunes, Peter Xu, 2017/03/27
- [Qemu-devel] [PATCH 4/5] hmp: info migrate_parameters format tunes, Peter Xu, 2017/03/27
- [Qemu-devel] [PATCH 5/5] cpu: throttle: fix throttle time slice, Peter Xu, 2017/03/27