qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v3 for-2.9 0/9] Fixes and cleanups around Socket


From: Max Reitz
Subject: Re: [Qemu-devel] [PATCH v3 for-2.9 0/9] Fixes and cleanups around SocketAddress
Date: Thu, 30 Mar 2017 23:42:21 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0

On 30.03.2017 19:43, Markus Armbruster wrote:
> What makes this 2.9 material is the crash bug fixed in PATCH 2 and the
> QAPI/QMP interface cleanups in PATCH 7+8.
> 
> v3:
> * PATCH 1-3,5 unchanged
> * PATCH 4 comments reworded [Max, Eric]
> * PATCH 6 comment tweak [Eric]
> * PATCH 7 comment typo, don't rely on enum equivalence [Eric]
> * PATCH 8 is PATCH v2 08+09 squashed together
> * PATCH 9 sd_parse_filename() fixed to again supply defaults for
>   omitted host and port, whitespace tidied up [Max]
> v2:
> * PATCH 01+02+04+05 unchanged
> * PATCH 03 error message improved, blank line [Max]
> * PATCH 06 commit message typo [Max]
> * PATCH 07 new, factored out of old PATCH 7
> * PATCH 08-10 updated, please re-review
> 
> Markus Armbruster (9):
>   nbd sockets vnc: Mark problematic address family tests TODO
>   char: Fix socket with "type": "vsock" address
>   io vnc sockets: Clean up SocketAddressKind switches
>   block: Document -drive problematic code and bugs
>   gluster: Prepare for SocketAddressFlat extension
>   qapi-schema: SocketAddressFlat variants 'vsock' and 'fd'
>   sockets: New helper socket_address_crumple()
>   nbd: Tidy up blockdev-add interface
>   sheepdog: Fix blockdev-add
> 
>  block.c                | 48 +++++++++++++++++++++++++--
>  block/file-posix.c     |  6 ++++
>  block/gluster.c        | 28 ++++++++++------
>  block/nbd.c            | 62 ++++++++++++++++++++--------------
>  block/nfs.c            |  7 ++++
>  block/rbd.c            |  6 ++++
>  block/sheepdog.c       | 90 
> ++++++++++++++++++++++++++++++++------------------
>  block/ssh.c            |  8 +++++
>  blockdev-nbd.c         |  1 +
>  chardev/char-socket.c  |  9 +++--
>  include/qemu/sockets.h | 11 ++++++
>  io/dns-resolver.c      |  7 ++--
>  qapi-schema.json       | 19 +++++------
>  qapi/block-core.json   |  6 ++--
>  ui/vnc.c               | 19 +++++++----
>  util/qemu-sockets.c    | 40 ++++++++++++++++++++--
>  16 files changed, 269 insertions(+), 98 deletions(-)

Thanks, fixed the typos in patch 4 and in the commit message of patch 8
and applied the series to my block branch:

https://github.com/XanClic/qemu/commits/block

Max

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]