Re: [Qemu-devel] [PATCH v4] hw/unicore32: remove wrong assertion in puv machine init

[Marcel Apfelbaum]

On 03/30/2017 07:34 PM, Suramya Shah wrote:

Hi,
Much better now, only a nit..

> Running QEMU with qemu-system-unicore32 without the kernel parameter results in 
> an assertion error.Assert should not be used to check user provided parameters. 
> Report an error and exit instead

You should break the above into a few lines, we don't "like" long lines.

Thanks,
Marcel

> Signed-off-by: Suramya Shah <address@hidden>
> ---
>  hw/unicore32/puv3.c | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/hw/unicore32/puv3.c b/hw/unicore32/puv3.c
> index 032078f..2c17cc9 100644
> --- a/hw/unicore32/puv3.c
> +++ b/hw/unicore32/puv3.c
> @@ -93,8 +93,11 @@ static void puv3_load_kernel(const char *kernel_filename)
>      if (kernel_filename == NULL && qtest_enabled()) {
>          return;
>      }
> -    assert(kernel_filename != NULL);
> -
> +    if (kernel_filename == NULL) {
> +        error_report("No kernel found");
> +        exit(1);
> +    }
> +
>      /* only zImage format supported */
>      size = load_image_targphys(kernel_filename, KERNEL_LOAD_ADDR,
>              KERNEL_MAX_SIZE);