Re: [Qemu-devel] [PATCH v3 for-2.9?] virtio: fix vring_align() on 64-bit windows

[Stefan Weil]

Am 28.03.2017 um 20:56 schrieb Andrew Baumann:
> > From: Eric Blake [mailto:address@hidden
> > > Is this needed for 2.9?
> >
> > Yes, it's a correctness bug that avoids miscompilation on 64-bit targets
> > where long is 32 bits (which, at the moment, is really just Windows).
>
> I agree, this should be in 2.9. I dropped the tag by accident.
>
> > > I wonder why I never before noticed
> > > a problem or got a bug report for this issue.
> >
> > Probably because so few people are testing on native Windows, and it
> > doesn't affect other platforms.
>
> In addition to that, you only notice it on virtio devices mapped above the 
> 32-bit limit...

I think that is the reason why most people don't get
that problem.

I also think that only a few people are testing on Windows,
but there seem to be more people than expected who simply
use it. Most of them will never complain when they have a
problem, but sometimes I also get e-mails which report
an issue.

By the way: I expect that more Windows users will be
attracted as soon as the HAXM acceleration works better
(Intel is just preparing a new HAXM version which fixes
CPUID, something which was reported to me by a Windows
user).

Stefan