[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH RFC v2 9/9] rbd: Reject invalid authentication metho
From: |
Markus Armbruster |
Subject: |
[Qemu-devel] [PATCH RFC v2 9/9] rbd: Reject invalid authentication methods |
Date: |
Fri, 24 Mar 2017 18:44:42 +0100 |
Signed-off-by: Markus Armbruster <address@hidden>
---
block/rbd.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/block/rbd.c b/block/rbd.c
index e962641..19fd820 100644
--- a/block/rbd.c
+++ b/block/rbd.c
@@ -15,6 +15,7 @@
#include <rbd/librbd.h>
#include "qapi/error.h"
+#include "qapi/util.h"
#include "qemu/error-report.h"
#include "block/block_int.h"
#include "crypto/secret.h"
@@ -506,11 +507,17 @@ static char *qemu_rbd_auth(QDict *options, Error **errp)
}
vals[i] = qstring_get_str(qobject_to_qstring(val));
+ if (qapi_enum_parse(RbdAuthSupport_lookup, vals[i],
+ RBD_AUTH_SUPPORT__MAX, -1, errp) < 0) {
+ rados_str = NULL;
+ goto out;
+ }
qdict_del(options, keybuf);
}
vals[i] = NULL;
rados_str = i ? g_strjoinv(";", (char **)vals) : NULL;
+out:
g_free(vals);
return rados_str;
}
--
2.7.4
- [Qemu-devel] [PATCH RFC v2 0/9] rbd: Clean up API and code, Markus Armbruster, 2017/03/24
- [Qemu-devel] [PATCH RFC v2 1/9] rbd: Reject -blockdev server.*.{numeric, to, ipv4, ipv6}, Markus Armbruster, 2017/03/24
- [Qemu-devel] [PATCH RFC v2 2/9] rbd: Fix to cleanly reject -drive without pool or image, Markus Armbruster, 2017/03/24
- [Qemu-devel] [PATCH RFC v2 4/9] rbd: Clean up after the previous commit, Markus Armbruster, 2017/03/24
- [Qemu-devel] [PATCH RFC v2 9/9] rbd: Reject invalid authentication methods,
Markus Armbruster <=
- [Qemu-devel] [PATCH RFC v2 7/9] rbd: Clean up qemu_rbd_create()'s detour through QemuOpts, Markus Armbruster, 2017/03/24
- [Qemu-devel] [PATCH RFC v2 8/9] rbd: Rewrite the code to extract list-valued options, Markus Armbruster, 2017/03/24
- [Qemu-devel] [PATCH RFC v2 3/9] rbd: Don't limit length of parameter values, Markus Armbruster, 2017/03/24
- [Qemu-devel] [PATCH RFC v2 5/9] rbd: Don't accept -drive driver=rbd, keyvalue-pairs=..., Markus Armbruster, 2017/03/24
- [Qemu-devel] [PATCH RFC v2 6/9] rbd: Clean up runtime_opts, fix -drive to reject filename, Markus Armbruster, 2017/03/24