[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] Dead code removal: removing code for unsupporte
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH] Dead code removal: removing code for unsupported DEPTH. |
Date: |
Fri, 24 Mar 2017 13:40:07 +0000 |
On 24 March 2017 at 13:36, Stefan Hajnoczi <address@hidden> wrote:
> Gerd, please reply if this is wrong, but here is a summary of the task:
>
> Some emulated graphics cards use qemu_console_surface() and that
> surface is always in 32 bits per pixel format. Therefore, code for
> dealing with other pixel formats can be removed.
>
> When looking for emulated graphics cards where this cleanup is
> possible, keep in mind that some of the code operates on the guest's
> frame buffer, whose pixel format is not under QEMU's control.
> Therefore we cannot assume that 32bpp is always used and this cleanup
> doesn't apply there. Limit yourself to code that uses
> qemu_console_surface() exclusively to access the surface and you
> should be fine. Other code is likely to need support for additional
> pixel formats.
Also worth pointing at an example of a patchset that does
this for some other device, eg Gerd's recent pl110 set,
as a guide to what's getting removed.
thanks
-- PMM
- [Qemu-devel] [PATCH] Dead code removal: removing code for unsupported DEPTH., iwona260909, 2017/03/16
- [Qemu-devel] [PATCH] Dead code removal: removing code for unsupported DEPTH., iwona260909, 2017/03/16
- Re: [Qemu-devel] [PATCH] Dead code removal: removing code for unsupported DEPTH., Peter Maydell, 2017/03/16
- Re: [Qemu-devel] [PATCH] Dead code removal: removing code for unsupported DEPTH., Gerd Hoffmann, 2017/03/16
- Re: [Qemu-devel] [PATCH] Dead code removal: removing code for unsupported DEPTH., Paolo Bonzini, 2017/03/16
- Re: [Qemu-devel] [PATCH] Dead code removal: removing code for unsupported DEPTH., Stefan Hajnoczi, 2017/03/24
- Re: [Qemu-devel] [PATCH] Dead code removal: removing code for unsupported DEPTH.,
Peter Maydell <=
- Re: [Qemu-devel] [PATCH] Dead code removal: removing code for unsupported DEPTH., Gerd Hoffmann, 2017/03/27
- Re: [Qemu-devel] [PATCH] Dead code removal: removing code for unsupported DEPTH., Iwona Kotlarska, 2017/03/29
- Re: [Qemu-devel] [PATCH] Dead code removal: removing code for unsupported DEPTH., Gerd Hoffmann, 2017/03/27