[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH qemu-ga] Start VSS Provider after install
From: |
Sameeh Jubran |
Subject: |
Re: [Qemu-devel] [PATCH qemu-ga] Start VSS Provider after install |
Date: |
Wed, 22 Mar 2017 12:58:05 +0200 |
On Tue, Mar 21, 2017 at 6:15 PM, Michael Roth <address@hidden>
wrote:
> Quoting Sameeh Jubran (2017-03-21 07:03:26)
> > Signed-off-by: Sameeh Jubran <address@hidden>
>
> What happens without this patch? Fresh installs don't report the
> fsfreeze interface as available?
>
It solves a bug (https://bugzilla.redhat.com/show_bug.cgi?id=1218937) that
was reported in bugzilla, however
thinking about it again this patch is not needed as the service should
only be running when it is needed.
>
> > ---
> > qga/vss-win32/install.cpp | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/qga/vss-win32/install.cpp b/qga/vss-win32/install.cpp
> > index f4160a3..7e38332 100644
> > --- a/qga/vss-win32/install.cpp
> > +++ b/qga/vss-win32/install.cpp
> > @@ -307,6 +307,7 @@ STDAPI COMRegister(void)
> > chk(put_Value(pObj, L"User", L"SYSTEM"));
> > chk(pUsersInRole->SaveChanges(&n));
> >
> > + chk(pCatalog->StartApplication(_bstr_t(QGA_PROVIDER_LNAME)));
> > out:
> > if (unregisterOnFailure && FAILED(hr)) {
> > COMUnregister();
> > --
> > 2.9.3
> >
>
>
--
Respectfully,
*Sameeh Jubran*
*Linkedin <https://il.linkedin.com/pub/sameeh-jubran/87/747/a8a>*
*Software Engineer @ Daynix <http://www.daynix.com>.*