[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 23/31] ram: Move migration_bitmap_rcu into RAMSt
From: |
Juan Quintela |
Subject: |
Re: [Qemu-devel] [PATCH 23/31] ram: Move migration_bitmap_rcu into RAMState |
Date: |
Mon, 20 Mar 2017 21:10:23 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) |
"Dr. David Alan Gilbert" <address@hidden> wrote:
> * Juan Quintela (address@hidden) wrote:
>> Once there, rename the type to be shorter.
>>
>> Signed-off-by: Juan Quintela <address@hidden>
>> ---
>> migration/ram.c | 79
>> ++++++++++++++++++++++++++++++---------------------------
>> 1 file changed, 42 insertions(+), 37 deletions(-)
>>
>> diff --git a/migration/ram.c b/migration/ram.c
>> index c14293c..d39d185 100644
>> --- a/migration/ram.c
>> +++ b/migration/ram.c
>> @@ -132,6 +132,19 @@ out:
>> return ret;
>> }
>>
>> +struct RAMBitmap {
>> + struct rcu_head rcu;
>> + /* Main migration bitmap */
>> + unsigned long *bmap;
>> + /* bitmap of pages that haven't been sent even once
>> + * only maintained and used in postcopy at the moment
>> + * where it's used to send the dirtymap at the start
>> + * of the postcopy phase
>> + */
>> + unsigned long *unsentmap;
>> +};
>> +typedef struct RAMBitmap RAMBitmap;
>> +
>
> I'm OK with this; although I can see the idea of naming it BitmapRcu,
> given that the actual bmap is inside that and most of the rest of the type
> is just the rcu wrapper.
It is the type, and now it also has the unsentmap.
atomic_rcu_read(&ram_state.bitmap_rcu)->bmap)
ends getting really long quite fast "p"
> Reviewed-by: Dr. David Alan Gilbert <address@hidden>
Thanks, Juan.
- [Qemu-devel] [PATCH 21/31] ram: Everything was init to zero, so use memset, (continued)
- [Qemu-devel] [PATCH 21/31] ram: Everything was init to zero, so use memset, Juan Quintela, 2017/03/15
- [Qemu-devel] [PATCH 18/31] ram: move xbzrle_cache_miss_rate into RAMState, Juan Quintela, 2017/03/15
- [Qemu-devel] [PATCH 17/31] ram: Move xbzrle_cache_miss into RAMState, Juan Quintela, 2017/03/15
- [Qemu-devel] [PATCH 16/31] ram: Move xbzrle_pages into RAMState, Juan Quintela, 2017/03/15
- [Qemu-devel] [PATCH 22/31] ram: move migration_bitmap_mutex into RAMState, Juan Quintela, 2017/03/15
- [Qemu-devel] [PATCH 20/31] ram: move migration_dirty_pages to RAMState, Juan Quintela, 2017/03/15
- [Qemu-devel] [PATCH 23/31] ram: Move migration_bitmap_rcu into RAMState, Juan Quintela, 2017/03/15
- [Qemu-devel] [PATCH 25/31] ram: Use the RAMState bytes_transferred parameter, Juan Quintela, 2017/03/15
- [Qemu-devel] [PATCH 26/31] ram: Remove ram_save_remaining, Juan Quintela, 2017/03/15
- [Qemu-devel] [PATCH 27/31] ram: Move last_req_rb to RAMState, Juan Quintela, 2017/03/15
- [Qemu-devel] [PATCH 24/31] ram: Move bytes_transferred into RAMState, Juan Quintela, 2017/03/15
- [Qemu-devel] [PATCH 29/31] ram: Remove dirty_bytes_rate, Juan Quintela, 2017/03/15
- [Qemu-devel] [PATCH 28/31] ram: Create ram_dirty_sync_count(), Juan Quintela, 2017/03/15