[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/2] save_vmstate: Convert to Error** from Monit
From: |
Juan Quintela |
Subject: |
Re: [Qemu-devel] [PATCH 1/2] save_vmstate: Convert to Error** from Monitor * |
Date: |
Mon, 20 Mar 2017 19:05:26 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) |
"Dr. David Alan Gilbert (git)" <address@hidden> wrote:
> From: "Dr. David Alan Gilbert" <address@hidden>
>
> A bit more consistent and it removes one of the less necessary uses
> of cur_mon.
>
> Signed-off-by: Dr. David Alan Gilbert <address@hidden>
Reviewed-by: Juan Quintela <address@hidden>
> @@ -2094,16 +2094,17 @@ int save_vmstate(Monitor *mon, const char *name)
> if (name) {
> ret = bdrv_all_delete_snapshot(name, &bs1, &local_err);
> if (ret < 0) {
> - error_reportf_err(local_err,
> - "Error while deleting snapshot on device '%s':
> ",
> - bdrv_get_device_name(bs1));
> + error_propagate(errp, local_err);
> + error_prepend(errp,
> + "Error while deleting snapshot on device '%s': ",
> + bdrv_get_device_name(bs1));
This is just magic O:-)