qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH for-2.10 10/16] block/qcow2: Lock s->lock in pre


From: Stefan Hajnoczi
Subject: Re: [Qemu-devel] [PATCH for-2.10 10/16] block/qcow2: Lock s->lock in preallocate()
Date: Mon, 20 Mar 2017 11:05:47 +0000
User-agent: Mutt/1.7.1 (2016-10-04)

On Mon, Mar 13, 2017 at 10:41:11PM +0100, Max Reitz wrote:
> preallocate() is and will be called only from places that do not lock
> s->lock: Currently that is qcow2_create2(), as of a future patch it will
> be called from qcow2_truncate(), too.
> 
> It therefore makes sense to move locking that mutex into preallocate()
> itself.
> 
> Signed-off-by: Max Reitz <address@hidden>
> ---
>  block/qcow2.c | 18 +++++++++++-------
>  1 file changed, 11 insertions(+), 7 deletions(-)

Reviewed-by: Stefan Hajnoczi <address@hidden>

Attachment: signature.asc
Description: PGP signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]