Re: [Qemu-devel] [PATCH v7 17/17] intel_iommu: enable vfio devices

[Aviv B.D.]

Hi Peter,
Thanks, I think that I should receive credit for this patch.

Please attribute it under my technion mail: address@hidden

The signed-off line should be:

Signed-off-by: Aviv Ben-David <address@hidden>

Thanks,
Aviv.

On Thu, Mar 16, 2017 at 6:05 AM, Peter Xu <address@hidden> wrote:

> On Tue, Feb 07, 2017 at 04:28:19PM +0800, Peter Xu wrote:
> > This patch is based on Aviv Ben-David (<address@hidden>)'s patch
> > upstream:
> >
> >   "IOMMU: enable intel_iommu map and unmap notifiers"
> >   https://lists.gnu.org/archive/html/qemu-devel/2016-11/msg01453.html
> >
> > However I removed/fixed some content, and added my own codes.
> >
> > Instead of translate() every page for iotlb invalidations (which is
> > slower), we walk the pages when needed and notify in a hook function.
> >
> > This patch enables vfio devices for VT-d emulation.
> >
> > And, since we already have vhost DMAR support via device-iotlb, a
> > natural benefit that this patch brings is that vt-d enabled vhost can
> > live even without ATS capability now. Though more tests are needed.
> >
>
> Hi, Michael,
>
> If there is any possiblility that this version be merged in the future
> at any point, would you please help add Aviv's sign-off into this
> patch as well right here (I think it should be before Jason's r-b):
>
> Signed-off-by: Aviv Ben-David <address@hidden>
>
> Since I think we should definitely give Aviv more credit since he's
> done a great work before (and devoted lots of time).
>
> (Aviv, please reply if you have other opinions, or I'll just make
>  myself bold)
>
> Thanks,
>
> > Reviewed-by: Jason Wang <address@hidden>
> > Signed-off-by: Peter Xu <address@hidden>
>
> [...]
>
> -- peterx
>