[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH for-2.9 v2] virtio: Fix error handling in virtio
From: |
Cornelia Huck |
Subject: |
Re: [Qemu-devel] [PATCH for-2.9 v2] virtio: Fix error handling in virtio_bus_device_plugged |
Date: |
Fri, 17 Mar 2017 13:39:52 +0100 |
On Fri, 17 Mar 2017 20:32:42 +0800
Fam Zheng <address@hidden> wrote:
> For one thing we shouldn't continue if an error happened, for the other
> two steps failing can cause an abort() in error_setg because we reuse
> the same errp blindly.
>
> Add error handling checks to fix both issues.
>
> Signed-off-by: Fam Zheng <address@hidden>
>
> ---
>
> v2: Don't forget the last errp -> &local_err. [Drew]
> ---
> hw/virtio/virtio-bus.c | 20 +++++++++++++++++---
> 1 file changed, 17 insertions(+), 3 deletions(-)
Reviewed-by: Cornelia Huck <address@hidden>