Re: [Qemu-devel] [PATCH v3 3/9] 9p: introduce a type for the 9p header

[Greg Kurz]

On Thu, 16 Mar 2017 13:01:52 -0700
Stefano Stabellini <address@hidden> wrote:

> Use the new type in virtio-9p-device.
> 
> Signed-off-by: Stefano Stabellini <address@hidden>
> CC: address@hidden
> CC: address@hidden
> CC: Aneesh Kumar K.V <address@hidden>
> CC: Greg Kurz <address@hidden>
> ---

Reviewed-by: Greg Kurz <address@hidden>

>  hw/9pfs/9p.h               | 6 ++++++
>  hw/9pfs/virtio-9p-device.c | 6 +-----
>  2 files changed, 7 insertions(+), 5 deletions(-)
> 
> diff --git a/hw/9pfs/9p.h b/hw/9pfs/9p.h
> index b7e8362..5312d8a 100644
> --- a/hw/9pfs/9p.h
> +++ b/hw/9pfs/9p.h
> @@ -119,6 +119,12 @@ static inline char *rpath(FsContext *ctx, const char 
> *path)
>  typedef struct V9fsPDU V9fsPDU;
>  struct V9fsState;
>  
> +typedef struct {
> +    uint32_t size_le;
> +    uint8_t id;
> +    uint16_t tag_le;
> +} QEMU_PACKED P9MsgHeader;
> +
>  struct V9fsPDU
>  {
>      uint32_t size;
> diff --git a/hw/9pfs/virtio-9p-device.c b/hw/9pfs/virtio-9p-device.c
> index 27a4a32..3782f43 100644
> --- a/hw/9pfs/virtio-9p-device.c
> +++ b/hw/9pfs/virtio-9p-device.c
> @@ -46,11 +46,7 @@ static void handle_9p_output(VirtIODevice *vdev, VirtQueue 
> *vq)
>      VirtQueueElement *elem;
>  
>      while ((pdu = pdu_alloc(s))) {
> -        struct {
> -            uint32_t size_le;
> -            uint8_t id;
> -            uint16_t tag_le;
> -        } QEMU_PACKED out;
> +        P9MsgHeader out;
>  
>          elem = virtqueue_pop(vq, sizeof(VirtQueueElement));
>          if (!elem) {

pgpjZAwHVJaTL.pgp
Description: OpenPGP digital signature