[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 2/2] virtio-scsi: Fix acquire/release in data
From: |
Fam Zheng |
Subject: |
Re: [Qemu-devel] [PATCH v2 2/2] virtio-scsi: Fix acquire/release in dataplane handlers |
Date: |
Fri, 17 Mar 2017 09:34:52 +0800 |
User-agent: |
Mutt/1.7.1 (2016-10-04) |
On Thu, 03/16 16:48, Ed Swierk wrote:
> On Tue, Mar 14, 2017 at 8:36 AM, Fam Zheng <address@hidden> wrote:
> > diff --git a/hw/scsi/virtio-scsi.c b/hw/scsi/virtio-scsi.c
> > index e7466d3..4939f1f 100644
> > --- a/hw/scsi/virtio-scsi.c
> > +++ b/hw/scsi/virtio-scsi.c
> > ...
> > bool virtio_scsi_handle_event_vq(VirtIOSCSI *s, VirtQueue *vq)
> > {
> > - virtio_scsi_acquire(s);
> > if (s->events_dropped) {
> > virtio_scsi_push_event(s, NULL, VIRTIO_SCSI_T_NO_EVENT, 0);
> > virtio_scsi_release(s);
>
> Did you intend to leave this virtio_scsi_release() call?
Oops, no, we should drop it.
Fam
>
> > return true;
> > }
> > - virtio_scsi_release(s);
> > return false;
> > }