qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH for-2.9 14/47] qapi: Prepare for requiring more


From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH for-2.9 14/47] qapi: Prepare for requiring more complete documentation
Date: Tue, 14 Mar 2017 11:08:35 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0

On 03/13/2017 01:18 AM, Markus Armbruster wrote:
> We currently neglect to check all enumeration values, common members
> of object types and members of alternate types are documented.
> Unsurprisingly, many aren't.

And some, like QKeyCode, would be a pain to document.

> 
> Add the necessary plumbing to find undocumented ones, except for
> variant members of object types.  Don't enforce anything just yet, but
> connect each QAPIDoc.ArgSection to its QAPISchemaMember.
> 
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
>  scripts/qapi.py | 110 
> +++++++++++++++++++++++++++++++++-----------------------
>  1 file changed, 65 insertions(+), 45 deletions(-)
> 

Lots of plumbing added, but I'm not spotting any obvious omissions.

Reviewed-by: Eric Blake <address@hidden>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]