[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH for-2.9 03/47] qapi: Back out doc comments added
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH for-2.9 03/47] qapi: Back out doc comments added just to please qapi.py |
Date: |
Tue, 14 Mar 2017 10:45:44 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) |
Marc-André Lureau <address@hidden> writes:
> Hi
>
> On Mon, Mar 13, 2017 at 10:36 AM Markus Armbruster <address@hidden>
> wrote:
>
>> This reverts commit 3313b61's changes to tests/qapi-schema/, except
>> for tests/qapi-schema/doc-*.
>>
>>
> Do we expect those files to change? If not, or not much, I think i't s
> rather better to keep the docs to exercise the parser in various
> situations.
Point taken, but I think the proper way to exercise doc comments is
systematic test cases in qapi-schema-test.json, or perhaps a separate
test schema we create just for exercising doc comments. Probably should
include a qapi2texi.py run complete with diff to golden .texi.
> It doesn't reduce the merits of the doc pragma though for other
> cases, which I wish I would have suggested (but I didn't like the initial
> series to grow more features)
We were both pretty desperate to get your work in without further delays.
- Re: [Qemu-devel] [PATCH for-2.9 27/47] qapi2texi: Generate documentation for variant members, (continued)
- [Qemu-devel] [PATCH for-2.9 17/47] qapi: The #optional tag is redundant, drop, Markus Armbruster, 2017/03/13
- [Qemu-devel] [PATCH for-2.9 37/47] qapi: Fix detection of bogus member documentation, Markus Armbruster, 2017/03/13
- [Qemu-devel] [PATCH for-2.9 03/47] qapi: Back out doc comments added just to please qapi.py, Markus Armbruster, 2017/03/13
- [Qemu-devel] [PATCH for-2.9 42/47] qapi: enum_types is a list used like a dict, make it one, Markus Armbruster, 2017/03/13
- [Qemu-devel] [PATCH for-2.9 45/47] qapi: Drop unused .check_clash() parameter schema, Markus Armbruster, 2017/03/13
- [Qemu-devel] [PATCH for-2.9 36/47] tests/qapi-schema: Improve coverage of bogus member docs, Markus Armbruster, 2017/03/13
- Re: [Qemu-devel] [PATCH for-2.9 00/47] qapi: Put type information back into QMP documentation, Marc-André Lureau, 2017/03/13