[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2] memory_region: Fix name comments
From: |
Dr. David Alan Gilbert |
Subject: |
Re: [Qemu-devel] [PATCH v2] memory_region: Fix name comments |
Date: |
Thu, 9 Mar 2017 16:13:52 +0000 |
User-agent: |
Mutt/1.7.1 (2016-10-04) |
* Paolo Bonzini (address@hidden) wrote:
>
>
> On 09/03/2017 16:27, Dr. David Alan Gilbert (git) wrote:
> > + * @name: Region name, becomes part of RAMBlock name used in migration
> > stream
> > + * must be unique within any device
> > * @size: size of the region; any subregions beyond this size will be
> > clipped
> > */
> > void memory_region_init(MemoryRegion *mr,
> > struct Object *owner,
> > const char *name,
> > uint64_t size);
>
> This one should not be necessary I guess?
Why? It's not static so something else could be calling it for
any use.
Dave
> Paolo
--
Dr. David Alan Gilbert / address@hidden / Manchester, UK