|
From: | Philippe Mathieu-Daudé |
Subject: | Re: [Qemu-devel] [PATCH for-2.9 v2] nbd/client: fix drop_sync [CVE-2017-2630] |
Date: | Tue, 7 Mar 2017 13:27:57 -0300 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 |
On 03/07/2017 12:16 PM, Eric Blake wrote:
From: Vladimir Sementsov-Ogievskiy <address@hidden> Comparison symbol is misused. It may lead to memory corruption. Introduced in commit 7d3123e. Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden> Message-Id: <address@hidden> [eblake: add CVE details, update conditional] Signed-off-by: Eric Blake <address@hidden> Reviewed-by: Marc-André Lureau <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
--- v2: use >= instead of >, fix R-b --- nbd/client.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/nbd/client.c b/nbd/client.c index 5c9dee3..3dc2564 100644 --- a/nbd/client.c +++ b/nbd/client.c @@ -94,7 +94,7 @@ static ssize_t drop_sync(QIOChannel *ioc, size_t size) char small[1024]; char *buffer; - buffer = sizeof(small) < size ? small : g_malloc(MIN(65536, size)); + buffer = sizeof(small) >= size ? small : g_malloc(MIN(65536, size)); while (size > 0) { ssize_t count = read_sync(ioc, buffer, MIN(65536, size));
[Prev in Thread] | Current Thread | [Next in Thread] |