[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 10/28] qmp: Improve QMP dispatch error messag
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v4 10/28] qmp: Improve QMP dispatch error messages |
Date: |
Mon, 6 Mar 2017 10:10:18 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 |
On 03/05/2017 02:01 AM, Markus Armbruster wrote:
>>> @@ -41,15 +41,17 @@ static QDict *qmp_dispatch_check_obj(const QObject
>>> *request, Error **errp)
>>>
>>> if (!strcmp(arg_name, "execute")) {
>>> if (qobject_type(arg_obj) != QTYPE_QSTRING) {
>>> - error_setg(errp, "QMP input object member '%s' expects
>>> '%s'",
>>> - "execute", "string");
>>> + error_setg(errp,
>>> + "QMP input object member '%s' must be %s",
>>> + "execute", "a string");
>>
>> let's avoid formatting like the rest of this patch.
>>
> Since substantial other work depends on this series, it needs to go in
> sooner rather than later. I'm therefore *dropping* this patch from the
> series. We can then bikeshed^Wpolish to our heart's content without
> holding up other work.
Agreed.
>
> That said: what about this?
Looks better. Do you want R-b now, or when you re-post it as an
official patch?
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
[Qemu-devel] [PATCH v4 13/28] qapi: Make QObject input visitor set *list reliably, Markus Armbruster, 2017/03/03
[Qemu-devel] [PATCH v4 03/28] qmp-test: New, covering basic QMP protocol, Markus Armbruster, 2017/03/03
[Qemu-devel] [PATCH v4 08/28] qmp: Drop duplicated QMP command object checks, Markus Armbruster, 2017/03/03
[Qemu-devel] [PATCH v4 09/28] qmp: Eliminate silly QERR_QMP_* macros, Markus Armbruster, 2017/03/03
[Qemu-devel] [PATCH v4 18/28] test-qobject-input-visitor: Use strict visitor, Markus Armbruster, 2017/03/03
[Qemu-devel] [PATCH v4 01/28] qga: Fix crash on non-dictionary QMP argument, Markus Armbruster, 2017/03/03