[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH] 9pfs: fix bogus fd check in local_remove()
From: |
Greg Kurz |
Subject: |
[Qemu-devel] [PATCH] 9pfs: fix bogus fd check in local_remove() |
Date: |
Fri, 03 Mar 2017 17:17:40 +0100 |
User-agent: |
StGit/0.17.1-20-gc0b1b-dirty |
This was spotted by Coverity as a fd leak. This is certainly true, but also
local_remove() would always return without doing anything, unless the fd is
zero, which is very unlikely.
(Coverity issue CID1371732)
Signed-off-by: Greg Kurz <address@hidden>
---
hw/9pfs/9p-local.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/9pfs/9p-local.c b/hw/9pfs/9p-local.c
index f22a3c3654db..5db7104334d6 100644
--- a/hw/9pfs/9p-local.c
+++ b/hw/9pfs/9p-local.c
@@ -1008,7 +1008,7 @@ static int local_remove(FsContext *ctx, const char *path)
int err = -1;
dirfd = local_opendir_nofollow(ctx, dirpath);
- if (dirfd) {
+ if (dirfd == -1) {
goto out;
}
- [Qemu-devel] [PATCH] 9pfs: fix bogus fd check in local_remove(),
Greg Kurz <=