[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] git master build failure in 9pfs
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] git master build failure in 9pfs |
Date: |
Fri, 3 Mar 2017 15:58:13 +0000 |
On 3 March 2017 at 15:55, G 3 <address@hidden> wrote:
> Here is the patch. I think we should let Mark or some else test it to see if
> it does fix the problem before a real patch is submitted.
>
> ---
> hw/9pfs/9p-util.h | 4 ++++
> 1 file changed, 4 insertions(+)
We can't take any patch without a Signed-off-by: line, not
even a three line one.
>
> diff --git a/hw/9pfs/9p-util.h b/hw/9pfs/9p-util.h
> index 091f3ce..254d2a9 100644
> --- a/hw/9pfs/9p-util.h
> +++ b/hw/9pfs/9p-util.h
> @@ -13,6 +13,10 @@
> #ifndef QEMU_9P_UTIL_H
> #define QEMU_9P_UTIL_H
>
> +#ifndef O_PATH
> + #define O_PATH 0
> +#endif
Could use a comment explaining why it's OK to define it in
a way that means it's a no-op on hosts without it.
> +
> static inline void close_preserve_errno(int fd)
> {
> int serrno = errno;
> --
> 2.10.2
thanks
-- PMM
- [Qemu-devel] git master build failure in 9pfs, Mark Cave-Ayland, 2017/03/02
- Re: [Qemu-devel] git master build failure in 9pfs, Programmingkid, 2017/03/02
- Re: [Qemu-devel] git master build failure in 9pfs, G 3, 2017/03/03
- Re: [Qemu-devel] git master build failure in 9pfs, Greg Kurz, 2017/03/03
- Re: [Qemu-devel] git master build failure in 9pfs, Daniel P. Berrange, 2017/03/03
- Re: [Qemu-devel] git master build failure in 9pfs, G 3, 2017/03/03
- Re: [Qemu-devel] git master build failure in 9pfs, Eric Blake, 2017/03/03
- Re: [Qemu-devel] git master build failure in 9pfs, Daniel P. Berrange, 2017/03/03
- Re: [Qemu-devel] git master build failure in 9pfs, Eric Blake, 2017/03/03
- Re: [Qemu-devel] git master build failure in 9pfs, Greg Kurz, 2017/03/03
- Re: [Qemu-devel] git master build failure in 9pfs, Eric Blake, 2017/03/03
- Re: [Qemu-devel] git master build failure in 9pfs, Greg Kurz, 2017/03/03