Re: [Qemu-devel] [PATCH] linux-user: Exclude more cpu model code when building s390x linux-user

[David Hildenbrand]

Am 02.03.2017 um 20:59 schrieb Bruce Rogers:
>>>> On 3/2/2017 at 12:53 PM, <address@hidden> wrote:
>> Am 02.03.2017 um 20:50 schrieb David Hildenbrand:
>>> Am 02.03.2017 um 20:33 schrieb Bruce Rogers:
>>>> Currently qemu-s390x segfaults. Avoid cpu model code which doesn't
>>>> apply in linux user case.
>>>
>>> That was also my impression, but it does apply. However, for now it
>>> doesn't matter, as also tcg isn't properly wired up.
>>>
>>> In general, linux-user can support _at least_ the same features as tcg,
>>> in theory even more (all that only apply to kernel space).
>>>
>>> We had a proper fix on this list by Richard Henderson, wonder what
>>> happened to that?
>>
>> Actually it was Stefan Weil :) cc-ing him.
> 
> I'm not all so familiar with this code, I only saw a failure and fixed it the
> most obvious way for me. I'm happy if there is a better fix out there.

Thanks for taking care, seems like the other patch somehow got stuck, so
thanks for bringing that up! :)

In my original series (when I thought linux-user wouldn't care about CPU
models), your patch would have been the correct fix!

> 
> BTW: I resent the patch again with SOB.
> 
> Brue
> 

-- 
Thanks,

David