[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 19/24] qapi: Improve how keyval input visitor re
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-devel] [PATCH 19/24] qapi: Improve how keyval input visitor reports unexpected dicts |
Date: |
Tue, 28 Feb 2017 18:51:42 +0100 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Am 27.02.2017 um 12:20 hat Markus Armbruster geschrieben:
> Incorrect option
>
> -blockdev node-name=foo,driver=file,filename=foo.img,aio.unmap
>
> is rejected with "Invalid parameter type for 'aio', expected: string".
> To make sense of this, you almost have to translate it into the
> equivalent QMP command
>
> { "execute": "blockdev-add", "arguments": { "node-name": "foo", "driver":
> "file", "filename": "foo.img", "aio": { "unmap": true } } }
>
> Improve the error message to "Parameters 'aio.*' are unexpected".
In fact, what I get (after fixing the previous review comments that
would make it crash) is "Expected '=' after parameter 'aio.unmap'". Only
if I add a value, I get the newly added message.
Doesn't make the patch less correct, though.
> Take care not to confuse the case "unexpected nested parameters"
> (i.e. the object is a QDict or QList) with the case "non-string scalar
> parameter". The latter is a misuse of the visitor, and should perhaps
> be an assertion. Note that test-qobject-input-visitor exercises this
> misuse in test_visitor_in_int_keyval(), test_visitor_in_bool_keyval()
> and test_visitor_in_number_keyval().
>
> Signed-off-by: Markus Armbruster <address@hidden>
Reviewed-by: Kevin Wolf <address@hidden>
- Re: [Qemu-devel] [PATCH 17/24] qapi: New qobject_input_visitor_new_str() for convenience, (continued)
- [Qemu-devel] [PATCH 02/24] tests: Fix gcov-files-test-qemu-opts-y, gcov-files-test-logging-y, Markus Armbruster, 2017/02/27
- [Qemu-devel] [PATCH 08/24] qobject: Propagate parse errors through qobject_from_jsonv(), Markus Armbruster, 2017/02/27
- [Qemu-devel] [PATCH 07/24] qapi: Factor out common qobject_input_get_keyval(), Markus Armbruster, 2017/02/27
- [Qemu-devel] [PATCH 23/24] keyval: Restrict key components to valid QAPI names, Markus Armbruster, 2017/02/27
- [Qemu-devel] [PATCH 19/24] qapi: Improve how keyval input visitor reports unexpected dicts, Markus Armbruster, 2017/02/27
- Re: [Qemu-devel] [PATCH 19/24] qapi: Improve how keyval input visitor reports unexpected dicts,
Kevin Wolf <=
- [Qemu-devel] [PATCH 06/24] qapi: Factor out common part of qobject input visitor creation, Markus Armbruster, 2017/02/27
- [Qemu-devel] [PATCH 22/24] qapi: New parse_qapi_name(), Markus Armbruster, 2017/02/27
- [Qemu-devel] [PATCH 03/24] keyval: New keyval_parse(), Markus Armbruster, 2017/02/27