[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 17/26] qapi: Drop unused non-strict qobject i
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH v2 17/26] qapi: Drop unused non-strict qobject input visitor |
Date: |
Tue, 28 Feb 2017 18:29:14 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) |
Eric Blake <address@hidden> writes:
> On 02/26/2017 03:43 PM, Markus Armbruster wrote:
>> The split between tests/test-qobject-input-visitor.c and
>> tests/test-qobject-input-strict.c now makes less sense than ever. The
>> next commit will take care of that.
>>
>> Signed-off-by: Markus Armbruster <address@hidden>
>> ---
>
> If I read Paolo's thread correctly, we were deferring his patches that
> relied on a non-strict visit until 2.10. And we can re-add non-strict
> via a new constructor, rather than adding back a bool parameter to all
> existing callers, so it doesn't hurt too badly that we are doing this
> now for 2.9 (or a revert always works, if it is justified).
Yup.
> Reviewed-by: Eric Blake <address@hidden>
>
>
>> @@ -276,7 +269,6 @@ static GenericList *qobject_input_next_list(Visitor *v,
>> GenericList *tail,
>> return tail->next;
>> }
>>
>> -
>> static void qobject_input_start_alternate(Visitor *v, const char *name,
>> GenericAlternate **obj, size_t
>> size,
>> bool promote_int, Error **errp)
>
> Spurious hunk?
Yes, will drop.
Thanks!
- [Qemu-devel] [PATCH v2 03/26] qmp-test: New, covering basic QMP protocol, (continued)
- [Qemu-devel] [PATCH v2 03/26] qmp-test: New, covering basic QMP protocol, Markus Armbruster, 2017/02/26
- [Qemu-devel] [PATCH v2 07/26] qmp: Eliminate silly QERR_QMP_* macros, Markus Armbruster, 2017/02/26
- [Qemu-devel] [PATCH v2 21/26] tests: Cover partial input visit of list, Markus Armbruster, 2017/02/26
- [Qemu-devel] [PATCH v2 24/26] tests: Cover input visit beyond end of list, Markus Armbruster, 2017/02/26
- [Qemu-devel] [PATCH v2 20/26] test-string-input-visitor: Improve list coverage, Markus Armbruster, 2017/02/26
- [Qemu-devel] [PATCH v2 17/26] qapi: Drop unused non-strict qobject input visitor, Markus Armbruster, 2017/02/26
- Re: [Qemu-devel] [PATCH v2 00/26] qapi: QMP dispatch and input visitor work, no-reply, 2017/02/26