Re: [Qemu-devel] [PATCH 15/24] test-visitor-serialization: Pass &error

qemu-devel

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 15/24] test-visitor-serialization: Pass &error_a

From:	Kevin Wolf
Subject:	Re: [Qemu-devel] [PATCH 15/24] test-visitor-serialization: Pass &error_abort to qobject_from_json()
Date:	Tue, 28 Feb 2017 18:09:19 +0100
User-agent:	Mutt/1.5.21 (2010-09-15)

Am 27.02.2017 um 12:20 hat Markus Armbruster geschrieben:
> qmp_deserialize() calls qobject_from_json() ignoring errors.  It
> passes the result to qobject_input_visitor_new(), which asserts it's
> not null.  Therefore, we can just as well pass &error_abort to
> qobject_from_json().
> 
> Signed-off-by: Markus Armbruster <address@hidden>

Reviewed-by: Kevin Wolf <address@hidden>

[Prev in Thread]

Current Thread

[Next in Thread]

[Qemu-devel] [PATCH 00/24] block: Command line option -blockdev, Markus Armbruster, 2017/02/27
- [Qemu-devel] [PATCH 10/24] qjson: Abort earlier on qobject_from_jsonf() misuse, Markus Armbruster, 2017/02/27
  - Re: [Qemu-devel] [PATCH 10/24] qjson: Abort earlier on qobject_from_jsonf() misuse, Kevin Wolf, 2017/02/28
- [Qemu-devel] [PATCH 11/24] test-qobject-input-visitor: Abort earlier on bad test input, Markus Armbruster, 2017/02/27
  - Re: [Qemu-devel] [PATCH 11/24] test-qobject-input-visitor: Abort earlier on bad test input, Kevin Wolf, 2017/02/28
- [Qemu-devel] [PATCH 01/24] test-qemu-opts: Cover qemu_opts_parse() of "no", Markus Armbruster, 2017/02/27
  - Re: [Qemu-devel] [PATCH 01/24] test-qemu-opts: Cover qemu_opts_parse() of "no", Kevin Wolf, 2017/02/28
- [Qemu-devel] [PATCH 16/24] monitor: Assert qmp_schema_json[] is sane, Markus Armbruster, 2017/02/27
  - Re: [Qemu-devel] [PATCH 16/24] monitor: Assert qmp_schema_json[] is sane, Kevin Wolf, 2017/02/28
- [Qemu-devel] [PATCH 15/24] test-visitor-serialization: Pass &error_abort to qobject_from_json(), Markus Armbruster, 2017/02/27
  - Re: [Qemu-devel] [PATCH 15/24] test-visitor-serialization: Pass &error_abort to qobject_from_json(), Kevin Wolf <=
- [Qemu-devel] [PATCH 12/24] qobject: Propagate parse errors through qobject_from_json(), Markus Armbruster, 2017/02/27
  - Re: [Qemu-devel] [PATCH 12/24] qobject: Propagate parse errors through qobject_from_json(), Kevin Wolf, 2017/02/28
  - Re: [Qemu-devel] [PATCH 12/24] qobject: Propagate parse errors through qobject_from_json(), Eric Blake, 2017/02/28
    - Re: [Qemu-devel] [PATCH 12/24] qobject: Propagate parse errors through qobject_from_json(), Markus Armbruster, 2017/02/28
- [Qemu-devel] [PATCH 20/24] docs/qapi-code-gen.txt: Clarify naming rules, Markus Armbruster, 2017/02/27
  - Re: [Qemu-devel] [PATCH 20/24] docs/qapi-code-gen.txt: Clarify naming rules, Kevin Wolf, 2017/02/28
- [Qemu-devel] [PATCH 13/24] block: More detailed syntax error reporting for JSON filenames, Markus Armbruster, 2017/02/27
  - Re: [Qemu-devel] [PATCH 13/24] block: More detailed syntax error reporting for JSON filenames, Kevin Wolf, 2017/02/28
- [Qemu-devel] [PATCH 05/24] test-keyval: Cover use with qobject input visitor, Markus Armbruster, 2017/02/27
  - Re: [Qemu-devel] [PATCH 05/24] test-keyval: Cover use with qobject input visitor, Kevin Wolf, 2017/02/28

Prev by Date: Re: [Qemu-devel] [PATCH 14/24] check-qjson: Test errors from qobject_from_json()
Next by Date: Re: [Qemu-devel] [PATCH v4 4/5] slirp: VMStatify socket level
Previous by thread: [Qemu-devel] [PATCH 15/24] test-visitor-serialization: Pass &error_abort to qobject_from_json()
Next by thread: [Qemu-devel] [PATCH 12/24] qobject: Propagate parse errors through qobject_from_json()
Index(es):
- Date
- Thread