[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 16/16] postcopy: Add extra check for COPY fun
From: |
Laurent Vivier |
Subject: |
Re: [Qemu-devel] [PATCH v3 16/16] postcopy: Add extra check for COPY function |
Date: |
Sun, 26 Feb 2017 20:16:42 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 |
On 24/02/2017 19:28, Dr. David Alan Gilbert (git) wrote:
> From: "Dr. David Alan Gilbert" <address@hidden>
>
> As an extra sanity check, make sure the region we're registering
> can perform UFFDIO_COPY; the COPY will fail later but this
> gives a cleaner failure.
>
> Signed-off-by: Dr. David Alan Gilbert <address@hidden>
> ---
> migration/postcopy-ram.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/migration/postcopy-ram.c b/migration/postcopy-ram.c
> index 102fb61..effbeb6 100644
> --- a/migration/postcopy-ram.c
> +++ b/migration/postcopy-ram.c
> @@ -378,6 +378,10 @@ static int ram_block_enable_notify(const char
> *block_name, void *host_addr,
> error_report("%s userfault register: %s", __func__, strerror(errno));
> return -1;
> }
> + if (!(reg_struct.ioctls & ((__u64)1 << _UFFDIO_COPY))) {
> + error_report("%s userfault: Region doesn't support COPY", __func__);
> + return -1;
> + }
>
> return 0;
> }
>
Reviewed-by: Laurent Vivier <address@hidden>
- [Qemu-devel] [PATCH v3 05/16] postcopy: enhance ram_block_discard_range for hugepages, (continued)
- [Qemu-devel] [PATCH v3 05/16] postcopy: enhance ram_block_discard_range for hugepages, Dr. David Alan Gilbert (git), 2017/02/24
- [Qemu-devel] [PATCH v3 07/16] postcopy: Plumb pagesize down into place helpers, Dr. David Alan Gilbert (git), 2017/02/24
- [Qemu-devel] [PATCH v3 10/16] postcopy: Mask fault addresses to huge page boundary, Dr. David Alan Gilbert (git), 2017/02/24
- [Qemu-devel] [PATCH v3 09/16] postcopy: Load huge pages in one go, Dr. David Alan Gilbert (git), 2017/02/24
- [Qemu-devel] [PATCH v3 12/16] postcopy: Allow hugepages, Dr. David Alan Gilbert (git), 2017/02/24
- [Qemu-devel] [PATCH v3 11/16] postcopy: Send whole huge pages, Dr. David Alan Gilbert (git), 2017/02/24
- [Qemu-devel] [PATCH v3 14/16] postcopy: Check for userfault+hugepage feature, Dr. David Alan Gilbert (git), 2017/02/24
- [Qemu-devel] [PATCH v3 13/16] postcopy: Update userfaultfd.h header, Dr. David Alan Gilbert (git), 2017/02/24
- [Qemu-devel] [PATCH v3 15/16] postcopy: Add doc about hugepages and postcopy, Dr. David Alan Gilbert (git), 2017/02/24
- [Qemu-devel] [PATCH v3 16/16] postcopy: Add extra check for COPY function, Dr. David Alan Gilbert (git), 2017/02/24
- Re: [Qemu-devel] [PATCH v3 16/16] postcopy: Add extra check for COPY function,
Laurent Vivier <=