Re: [Qemu-devel] [PATCH 09/21] qapi: Improve a QObject input visitor error message

[Eric Blake]

On 02/23/2017 03:45 PM, Markus Armbruster wrote:
> The QObject input visitor has three error message formats:
> 
> * Parameter '%s' is missing
> * "Invalid parameter type for '%s', expected: %s"
> * "QMP input object member '%s' is unexpected"
> 
> The '%s' are member names (or "null", but I'll fix that later).
> 
> The last error message calls the thing "QMP input object member"
> instead of "parameter".  Misleading when the visitor is used on
> QObjects that don't come from QMP.  Change it to "Parameter '%s' is
> unexpected".
> 
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
>  qapi/qobject-input-visitor.c | 3 +--
>  tests/test-qga.c             | 2 +-
>  2 files changed, 2 insertions(+), 3 deletions(-)
> 

Reviewed-by: Eric Blake <address@hidden>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature