Re: [Qemu-devel] [PULL 00/19] Block layer patches

[no-reply]

Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: address@hidden
Type: series
Subject: [Qemu-devel] [PULL 00/19] Block layer patches

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

# Useful git options
git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 - [tag update]      patchew/address@hidden -> patchew/address@hidden
 * [new tag]         patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
88f046d tests: Use opened block node for block job tests
3b26fc9 vvfat: Use opened node as backing file
b7dea37 block: Add bdrv_new_open_driver()
06e0d10 block: Factor out bdrv_open_driver()
a5063d5 block: Use BlockBackend for image probing
e71e684 block: Factor out bdrv_open_child_bs()
0a67f78 block: Attach bs->file only during .bdrv_open()
9532e71 block: Pass BdrvChild to bdrv_truncate()
19d5c41 mirror: Resize active commit base in mirror_run()
ad44d55 qcow2: Use BB for resizing in qcow2_amend_options()
df54cc4 blockdev: Use BlockBackend to resize in qmp_block_resize()
c437206 iotests: Fix another race in 030
494b0ae qemu-img: Improve documentation for PREALLOC_MODE_FALLOC
39ee155 qemu-img: Truncate before full preallocation
72360e3 qemu-img: Add tests for raw image preallocation
f9bf4f9 qemu-img: Do not truncate before preallocation
3515c08 qemu-iotests: redirect nbd server stdout to /dev/null
dc728ce qemu-iotests: add ability to exclude certain protocols from tests
abc2f9d qemu-iotests: Test 137 only supports 'file' protocol

=== OUTPUT BEGIN ===
Checking PATCH 1/19: qemu-iotests: Test 137 only supports 'file' protocol...
Checking PATCH 2/19: qemu-iotests: add ability to exclude certain protocols 
from tests...
Checking PATCH 3/19: qemu-iotests: redirect nbd server stdout to /dev/null...
Checking PATCH 4/19: qemu-img: Do not truncate before preallocation...
Checking PATCH 5/19: qemu-img: Add tests for raw image preallocation...
Checking PATCH 6/19: qemu-img: Truncate before full preallocation...
Checking PATCH 7/19: qemu-img: Improve documentation for PREALLOC_MODE_FALLOC...
Checking PATCH 8/19: iotests: Fix another race in 030...
Checking PATCH 9/19: blockdev: Use BlockBackend to resize in 
qmp_block_resize()...
Checking PATCH 10/19: qcow2: Use BB for resizing in qcow2_amend_options()...
Checking PATCH 11/19: mirror: Resize active commit base in mirror_run()...
Checking PATCH 12/19: block: Pass BdrvChild to bdrv_truncate()...
Checking PATCH 13/19: block: Attach bs->file only during .bdrv_open()...
Checking PATCH 14/19: block: Factor out bdrv_open_child_bs()...
Checking PATCH 15/19: block: Use BlockBackend for image probing...
Checking PATCH 16/19: block: Factor out bdrv_open_driver()...
Checking PATCH 17/19: block: Add bdrv_new_open_driver()...
Checking PATCH 18/19: vvfat: Use opened node as backing file...
ERROR: "(foo*)" should be "(foo *)"
#33: FILE: block/vvfat.c:2971:
+    .instance_size      = sizeof(void*),

ERROR: "(foo**)" should be "(foo **)"
#44: FILE: block/vvfat.c:3042:
+    *(void**) backing->opaque = s;

total: 2 errors, 0 warnings, 25 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 19/19: tests: Use opened block node for block job tests...
=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden