qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] target-s390x: Implement stfl and stfle


From: David Hildenbrand
Subject: Re: [Qemu-devel] [PATCH] target-s390x: Implement stfl and stfle
Date: Fri, 24 Feb 2017 17:28:54 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0

Am 24.02.2017 um 16:22 schrieb Michal Marek:
> On 2017-02-24 15:51, address@hidden wrote:
>> Hi,
>>
>> This series seems to have some coding style problems. See output below for
>> more information:
> [...]
>> === OUTPUT BEGIN ===
>> Checking PATCH 1/1: target-s390x: Implement stfl and stfle...
>> ERROR: braces {} are necessary for all arms of this statement
>> #108: FILE: target/s390x/misc_helper.c:522:
>> +    if (need <= len)
>> [...]
>> +    else
>> [...]
> 
> I was not aware of this coding style requirement. I will wait if I get
> more feedback from humans and resubmit.
> 

Yes, QEMU (in contrast to the kernel) always requires {} for
if/else/for/while....

-- 
Thanks,

David



reply via email to

[Prev in Thread] Current Thread [Next in Thread]