Re: [Qemu-devel] [PATCH RESEND] aarch64: Change ext type to TCGType to fix warnings

[Richard Henderson]

On 02/18/2017 02:43 AM, Pranith Kumar wrote:
> To fix the following warnings:
>
> In file included from /users/pranith/qemu/tcg/tcg.c:255:
> /users/pranith/qemu/tcg/aarch64/tcg-target.inc.c:879:24: warning: implicit 
> conversion from enumeration type 'TCGMemOp' (aka 'enum TCGMemOp') to different 
> enumeration type 'TCGType' (aka 'enum TCGType')
>       [-Wenum-conversion]
>         tcg_out_cmp(s, ext, a, b, b_const);
>         ~~~~~~~~~~~    ^~~
> /users/pranith/qemu/tcg/aarch64/tcg-target.inc.c:893:36: warning: implicit 
> conversion from enumeration type 'TCGMemOp' (aka 'enum TCGMemOp') to different 
> enumeration type 'TCGType' (aka 'enum TCGType')
>       [-Wenum-conversion]
>         tcg_out_insn(s, 3201, CBZ, ext, a, offset);
>         ~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~
> /users/pranith/qemu/tcg/aarch64/tcg-target.inc.c:389:65: note: expanded from 
> macro 'tcg_out_insn'
>     glue(tcg_out_insn_,FMT)(S, glue(glue(glue(I,FMT),_),OP), ## __VA_ARGS__)
>                                                                 ^
> /users/pranith/qemu/tcg/aarch64/tcg-target.inc.c:895:37: warning: implicit 
> conversion from enumeration type 'TCGMemOp' (aka 'enum TCGMemOp') to different 
> enumeration type 'TCGType' (aka 'enum TCGType')
>       [-Wenum-conversion]
>         tcg_out_insn(s, 3201, CBNZ, ext, a, offset);
>         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~
> /users/pranith/qemu/tcg/aarch64/tcg-target.inc.c:389:65: note: expanded from 
> macro 'tcg_out_insn'
>     glue(tcg_out_insn_,FMT)(S, glue(glue(glue(I,FMT),_),OP), ## __VA_ARGS__)
>                                                                 ^
> /users/pranith/qemu/tcg/aarch64/tcg-target.inc.c:1610:27: warning: implicit 
> conversion from enumeration type 'TCGType' (aka 'enum TCGType') to different 
> enumeration type 'TCGMemOp' (aka 'enum TCGMemOp')
>       [-Wenum-conversion]
>         tcg_out_brcond(s, ext, a2, a0, a1, const_args[1], arg_label(args[3]));
>         ~~~~~~~~~~~~~~    ^~~
>
> Signed-off-by: Pranith Kumar <address@hidden>
> ---
>  tcg/aarch64/tcg-target.inc.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

I haven't seen this, but I've also just noticed that the gcc farm aarch64 
machine is using gcc 4.8.5, so that could be it.

Applied.


r~